Closed Bug 1001561 Opened 12 years ago Closed 12 years ago

remove getAllTabs() from sdk/page-mod

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evold, Assigned: evold)

Details

Attachments

(1 file)

https://github.com/mozilla/addon-sdk/pull/1472
46 bytes, text/x-github-pull-request
zer0
: review+
Details | Review
There is a method called `getAllTabs` in the sdk/page-mod module which I would expect to be in the sdk/tabs/utils module.
Summary: move getAllTabs() from sdk/page-mod to sdk/tabs/utils → remove getAllTabs() from sdk/page-mod
Assignee: nobody → evold
Comment on attachment 8412906 [details] [review] https://github.com/mozilla/addon-sdk/pull/1472 Just check the minor nit in the comment, but it's okay either way, up to you.
Attachment #8412906 - Flags: review?(zer0) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/15ed5f4776f552858479d8183f65eb1049d6f55b Bug 1001561 - remove getAllTabs() from sdk/page-mod https://github.com/mozilla/addon-sdk/commit/a4fd377a79a2dd69c416fee15c91103036e0c1ff Merge pull request #1472 from erikvold/1001561 Bug 1001561 - remove getAllTabs() from sdk/page-mod r=@ZER0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: