Closed Bug 1001568 Opened 10 years ago Closed 10 years ago

[Clock] Refactor AlarmsDB and Alarm

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Clock
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S5 (4july)

People

(Reporter: mcav, Assigned: mcav)

Details

(Whiteboard: [p=8])

Attachments

(1 file)

Pull Request
46 bytes, text/x-github-pull-request
mmedeiros
: review+
Details | Review 
      No description provided.
Attached file Pull Request — 
This refactoring targets AlarmsDB and Alarm. I've renamed AlarmsDB to AlarmDatabase, which is the reason you see so many changes. Best to view it in your cool diff viewer thing you have.
Assignee: nobody → m
Status: NEW → ASSIGNED
Attachment #8412967 - Flags: review?(mmedeiros)
Whiteboard: [p=8]
Target Milestone: --- → 1.4 S6 (25apr)
Target Milestone: 1.4 S6 (25apr) → 2.0 S1 (9may)
Comment on attachment 8412967 [details] [review]
Pull Request

a few comments on GH, but looks good to me. Code is simpler to understand + better abstractions.
Attachment #8412967 - Flags: review?(mmedeiros) → review+
Target Milestone: 2.0 S1 (9may) → 2.0 S2 (23may)
Target Milestone: 2.0 S2 (23may) → 2.0 S3 (6june)
Target Milestone: 2.0 S3 (6june) → 2.0 S4 (20june)
Target Milestone: 2.0 S4 (20june) → 2.0 S5 (4july)
Green gaia-try: https://tbpl.mozilla.org/?tree=Gaia-Try&rev=4c328e9e4d0345d5375b5209294bf123f2145208

Landed on master: https://github.com/mozilla-b2g/gaia/commit/eb0c3f7209686081410791311225157a575f7f5f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: