User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.75.14 (KHTML, like Gecko) Version/7.0.3 Safari/537.75.14 Steps to reproduce: Compiled for android with the "--disable-tests" option Actual results: Build failed trying to link file in objdir/security/manager/ssl/tests/unit/tlsserver/cmd - missing ../../../../../../pkix/test/lib/libpkixtestutil.a Expected results: The tests in security/manager/ssl/tests should not be run if --disable-tests is set.
The attached patch fixes the issue by including the tests directory only when building tests
Patch needs a reviewer set see - https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed
Status: UNCONFIRMED → NEW
Component: Build Config & IDE Support → Security: PSM
Ever confirmed: true
Product: Firefox for Android → Core
Attachment #8412819 - Flags: review+
Comment on attachment 8413236 [details] [diff] [review] Formatted patch for HG and changed the commit message Carrying over r+
Attachment #8413236 - Flags: review+
(In reply to Nathan Toone from comment #5) > Comment on attachment 8413236 [details] [diff] [review] > Formatted patch for HG and changed the commit message > > Carrying over r+ you should have r=brian in the commit message.
Added r=brian to the commit message
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Please needinfo me if this needs additional testing before we release.
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.