Closed
Bug 1001585
Opened 11 years ago
Closed 11 years ago
Build fails with --disable-tests option
Categories
(Core :: Security: PSM, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: toonetown, Assigned: toonetown)
References
Details
Attachments
(1 file, 2 obsolete files)
|
689 bytes,
patch
|
toonetown
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.75.14 (KHTML, like Gecko) Version/7.0.3 Safari/537.75.14
Steps to reproduce:
Compiled for android with the "--disable-tests" option
Actual results:
Build failed trying to link file in objdir/security/manager/ssl/tests/unit/tlsserver/cmd - missing ../../../../../../pkix/test/lib/libpkixtestutil.a
Expected results:
The tests in security/manager/ssl/tests should not be run if --disable-tests is set.
|
Assignee | |
Comment 1•11 years ago
|
||
The attached patch fixes the issue by including the tests directory only when building tests
|
||
Updated•11 years ago
|
Attachment #8412819 -
Attachment is patch: true
Attachment #8412819 -
Attachment mime type: text/x-patch → text/plain
|
||
Comment 2•11 years ago
|
||
Patch needs a reviewer set see - https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed
Status: UNCONFIRMED → NEW
Component: Build Config & IDE Support → Security: PSM
Ever confirmed: true
Product: Firefox for Android → Core
|
||
Updated•11 years ago
|
Attachment #8412819 -
Flags: review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8412819 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 8413236 [details] [diff] [review]
Formatted patch for HG and changed the commit message
Carrying over r+
Attachment #8413236 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
(In reply to Nathan Toone from comment #5)
> Comment on attachment 8413236 [details] [diff] [review]
> Formatted patch for HG and changed the commit message
>
> Carrying over r+
you should have r=brian in the commit message.
|
|
Assignee | |
Comment 7•11 years ago
|
||
Added r=brian to the commit message
Attachment #8413236 -
Attachment is obsolete: true
Attachment #8413244 -
Flags: review+
|
||
Comment 8•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
|
||
Comment 10•11 years ago
|
||
Please needinfo me if this needs additional testing before we release.
QA Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•