1001585 - Build fails with --disable-tests option

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Nathan Toone [:toonetown]]

Attachment: disable-tests.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.75.14 (KHTML, like Gecko) Version/7.0.3 Safari/537.75.14

Steps to reproduce:

Compiled for android with the "--disable-tests" option


Actual results:

Build failed trying to link file in objdir/security/manager/ssl/tests/unit/tlsserver/cmd - missing ../../../../../../pkix/test/lib/libpkixtestutil.a


Expected results:

The tests in security/manager/ssl/tests should not be run if --disable-tests is set.

Comment 1

[Nathan Toone [:toonetown]]

The attached patch fixes the issue by including the tests directory only when building tests

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Patch needs a reviewer set see - https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed

Comment 4

[Nathan Toone [:toonetown]]

Attachment: Formatted patch for HG and changed the commit message

Comment 5

[Nathan Toone [:toonetown]]

Comment on attachment 8413236 [details] [diff] [review]
Formatted patch for HG and changed the commit message

Carrying over r+

Comment 6

[Bill Gianopoulos [:WG9s]]

(In reply to Nathan Toone from comment #5)
> Comment on attachment 8413236 [details] [diff] [review]
> Formatted patch for HG and changed the commit message
> 
> Carrying over r+

you should have r=brian in the commit message.

Comment 7

[Nathan Toone [:toonetown]]

Attachment: Formatted patch for HG and changed the commit message

Added r=brian to the commit message

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7dd1a04ced80

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7dd1a04ced80

Comment 10

[u279076]

Please needinfo me if this needs additional testing before we release.