Build fails with --disable-tests option

RESOLVED FIXED in mozilla31

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: toonetown, Assigned: toonetown)

Tracking

Trunk
mozilla31
x86
macOS
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

5 years ago
Posted patch disable-tests.patch (obsolete) — Splinter Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.75.14 (KHTML, like Gecko) Version/7.0.3 Safari/537.75.14

Steps to reproduce:

Compiled for android with the "--disable-tests" option


Actual results:

Build failed trying to link file in objdir/security/manager/ssl/tests/unit/tlsserver/cmd - missing ../../../../../../pkix/test/lib/libpkixtestutil.a


Expected results:

The tests in security/manager/ssl/tests should not be run if --disable-tests is set.
Assignee

Comment 1

5 years ago
The attached patch fixes the issue by including the tests directory only when building tests
Attachment #8412819 - Attachment is patch: true
Attachment #8412819 - Attachment mime type: text/x-patch → text/plain
Patch needs a reviewer set see - https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed
Status: UNCONFIRMED → NEW
Component: Build Config & IDE Support → Security: PSM
Ever confirmed: true
Product: Firefox for Android → Core
Duplicate of this bug: 1001825
Assignee

Comment 4

5 years ago
Attachment #8412819 - Attachment is obsolete: true
Assignee

Comment 5

5 years ago
Comment on attachment 8413236 [details] [diff] [review]
Formatted patch for HG and changed the commit message

Carrying over r+
Attachment #8413236 - Flags: review+
Assignee

Updated

5 years ago
Keywords: checkin-needed
(In reply to Nathan Toone from comment #5)
> Comment on attachment 8413236 [details] [diff] [review]
> Formatted patch for HG and changed the commit message
> 
> Carrying over r+

you should have r=brian in the commit message.
Assignee

Comment 7

5 years ago
Added r=brian to the commit message
Attachment #8413236 - Attachment is obsolete: true
Attachment #8413244 - Flags: review+

Updated

5 years ago
Assignee: nobody → nathan
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/7dd1a04ced80
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Please needinfo me if this needs additional testing before we release.
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.