Closed
Bug 1001625
Opened 11 years ago
Closed 11 years ago
Create a unified build flag to enable all haida features and preferences
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S1 (9may)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [p=2],[systemsfe])
Attachments
(1 file)
Proposal: Remove the ROCKETBAR build flag in favor of a unified build flag to enable all haida features and preferences. The flag would enable the following features:
Rocketbar
Settings Drawer
Notifications Tray
Task Manager
Edge Gestures
System Browser
Opt into vertical homescreen
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Whiteboard: [p=2],[systemsfe]
Target Milestone: --- → 2.0 S1 (9may)
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8413073 [details] [review]
Github pull request
Hi Yuren - please review this whenever you have time. Thanks!
Attachment #8413073 -
Flags: review?(yurenju.mozilla)
Comment 3•11 years ago
|
||
Huh? If homescreen and edge gestures ship in 2.0 and everything else doesn't ship until 2.1 but work has already started, don't we need a way to toggle them independently?
Assignee | ||
Comment 4•11 years ago
|
||
In that case HAIDA=1 can just enable the remaining features. (Rocketbar, Settings Drawer, Notifications Tray).
It doesn't seem necessary to have multiple levels for the rocketbar flag now that we've made progress on the UI and it isn't enabled by default.
Comment 5•11 years ago
|
||
OK, makes sense.
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 8413073 [details] [review]
Github pull request
Adding some more reviewers in case Yuren is busy. Anyone have time? Thanks!
Attachment #8413073 -
Flags: review?(poirot.alex)
Attachment #8413073 -
Flags: review?(21)
Comment 7•11 years ago
|
||
Comment on attachment 8413073 [details] [review]
Github pull request
r=yurenju if nits are addressed.
Attachment #8413073 -
Flags: review?(yurenju.mozilla)
Attachment #8413073 -
Flags: review?(poirot.alex)
Attachment #8413073 -
Flags: review?(21)
Attachment #8413073 -
Flags: review+
Comment 8•11 years ago
|
||
Glad that Yuren has been faster :)
Assignee | ||
Comment 9•11 years ago
|
||
Thanks for taking a look guys!
Landed: https://github.com/mozilla-b2g/gaia/commit/94ffc335253ad226106b0e601af49f3eea22dfed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•