1001635 - Add relations for MathMLAccessibles

Status: NEW

(Core :: Disability Access APIs, enhancement)

Description

[Jonathan Wei [:jwei]]

Set up relations described on https://wiki.mozilla.org/Accessibility/MathML.

Comment 1

[Jonathan Wei [:jwei]]

Attachment: MathML relations WIP

Added all relations listed on the wiki page. The necessity of these relations is still in discussion (forward direction, e.g. fraction -> numerator, due to the rigidity of the MathML spec, and the backwards direction, e.g. numerator -> fraction, due to various other factors).

Comment 2

[Jonathan Wei [:jwei]]

Attachment: MathML relations

Switched to utils class for common MathML implementations.

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 8434644 [details] [diff] [review]
MathML relations

Review of attachment 8434644 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

::: accessible/src/generic/MathMLUtils.cpp
@@ +534,5 @@
> +    case RelationType::MATHML_ROW_FOR: {
> +      if (accRole != roles::MATHML_ROW)
> +        break;
> +
> +      aRelation->AppendIter(new ChildIterator(aAccessible));

this is rather crazy since its full analogue of GetChildren() but that may be ok for now. We'd need to run all of these through some implementation to see what makes sense and what should go away

Comment 4

[Frédéric Wang (:fredw)]

Attachment: MathML relations

Unbitrotting...

Comment 5

[Frédéric Wang (:fredw)]

Attachment: MathML relations

Unbitrot

Comment 6

[Frédéric Wang (:fredw)]

Attachment: MathML relations

Unbitrotting the patch again. However, the way we map MathML elements to roles has changed in Alexander's patch for bug 1001635, so this might need some refactoring...

Comment 7

[alexander :surkov (:asurkov)]

yes, I'll handle it

Comment 8

[alexander :surkov (:asurkov)]

Attachment: old wip (put relations into MarkupMap)

Comment 9

[Frédéric Wang (:fredw)]

Attachment: Put relations into MarkupMap

This is the continuation of attachment 8623966 [details] [diff] [review] to move relations into MarkupMap. IIUC, if we have

<mfrac>
  [NUMERATOR]
  [DENOMINATOR]
</mfrac>

then we can implement the relation RELATION_MATHML_NUMERATOR by associating the relation to the nsGkAtoms::mfrac_ element. However, to implement the converse relation RELATION_MATHML_DENOMINATOR_OF, we would need to associate it to *any* MathML elements that can potentially be a numerator. So I don't think this map stuff is really a good idea to implement Jonathan's relations.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:Jamie, could you have a look please?
For more information, please visit auto_nag documentation.