Closed Bug 1001659 Opened 8 years ago Closed 8 years ago

Update Modern for bug 948901 changes on directory listings

Categories

(SeaMonkey :: Themes, defect)

Product:
SeaMonkey
Component:
Themes
Version:
SeaMonkey 2.28 Branch
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.28

People

(Reporter: neil, Assigned: rsx11m.pub)

Details

(Keywords: modern)

Attachments

(1 file)

Proposed fix
734 bytes, patch
neil
: review+
Details | Diff | Splinter Review 
Bug 948901 tweaked the content of HTML directory/FTP listings slightly.
Severity: normal → trivial
Keywords: modern
Summary: Update Modern for bug 948901 changes → Update Modern for bug 948901 changes on directory listings
Version: unspecified → SeaMonkey 2.28 Branch
Attached patch Proposed fix — — Splinter Review 
(Quoting neil@parkwaycc.co.uk from bug 948901 comment #23)
> (In reply to Alfred Kayser from bug 948901 comment #21)
> > What is this change about?
> > 80 	tbody > tr:hover {
> > 80 	body > table > tbody > tr:hover {
> 
> In order to get the ellipsis to work, I can't put the file name directly
> inside the table cell, instead I have to nest it inside a table with fixed
> table layout. This change simply ensures that the hover rule only applies to
> the outer table.

So, that should be all that's needed?

Without the patch, I see a double border, the intended one and a new one around the file name. With the patch, the inner border is no longer there on hover (same as on aurora build without bug 948901).
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #8413112 - Flags: review?(neil)
Attachment #8413112 - Flags: review?(neil) → review+
Thanks and push for comm-central, please.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/c3d0ef6e2ac0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.28
You need to log in before you can comment on or make changes to this bug.