Closed
Bug 1001681
Opened 11 years ago
Closed 11 years ago
webapprt-test-chrome fails on this.Task is undefined
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla31
People
(Reporter: myk, Assigned: myk)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
2.73 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
The fix for bug 1000512 broke running the webapprt-test-chrome tests because it references this.Task in the global scope, where it isn't defined, resulting in the exception "JavaScript error: chrome://mochikit/content/browser-test.js, line 317: this.Task is undefined".
Here's a fix. Note that there's no point in lazily-getting Task.jsm in the global scope, as it's used immediately in the Tester.prototype.nextTest property declaration.
Attachment #8412973 -
Flags: review?(jmaher)
|
||
Comment 1•11 years ago
|
||
Thank you Myk, I was bisecting to find what caused the regression in the webapprt-test-chrome tests, as it turns out I did cause it!
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8412973 [details] [diff] [review]
fix-webapprt-test-chrome.diff
Review of attachment 8412973 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks Myk
Attachment #8412973 -
Flags: review?(jmaher) → review+
|
Assignee | |
Comment 3•11 years ago
|
||
Target Milestone: --- → mozilla31
Version: unspecified → Trunk
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•