Closed Bug 1001681 Opened 10 years ago Closed 10 years ago

webapprt-test-chrome fails on this.Task is undefined

Categories

(Testing :: Mochitest, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: myk, Assigned: myk)

References

Details

(Keywords: regression)

Attachments

(1 file)

The fix for bug 1000512 broke running the webapprt-test-chrome tests because it references this.Task in the global scope, where it isn't defined, resulting in the exception "JavaScript error: chrome://mochikit/content/browser-test.js, line 317: this.Task is undefined".

Here's a fix.  Note that there's no point in lazily-getting Task.jsm in the global scope, as it's used immediately in the Tester.prototype.nextTest property declaration.
Attachment #8412973 - Flags: review?(jmaher)
Thank you Myk, I was bisecting to find what caused the regression in the webapprt-test-chrome tests, as it turns out I did cause it!
Comment on attachment 8412973 [details] [diff] [review]
fix-webapprt-test-chrome.diff

Review of attachment 8412973 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Myk
Attachment #8412973 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa70674b866e
Target Milestone: --- → mozilla31
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/fa70674b866e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.