Stop suppressing the xmanager log file

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

unspecified
mozilla32
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
When suppressing logs (aka displaying output messages), we still need the xmanager output to go into its log file, because its port number is read out of it (yes, it's ugly.) So pipe through tee instead of redirecting to the log.
Assignee

Comment 1

5 years ago
Sorry njn, but you (1) ran into a problem recently with a silent error message in the Hf build and (2) have mentioned using Perl in the past.

This script is used for running the rooting analysis.
Attachment #8412991 - Flags: review?(n.nethercote)
Comment on attachment 8412991 [details] [diff] [review]
Stop suppressing the xmanager log file

Review of attachment 8412991 [details] [diff] [review]:
-----------------------------------------------------------------

Is it worth factoring these two changed bits out into a function? Not sure. r=me either way.

::: js/src/devtools/rootAnalysis/run_complete
@@ +214,5 @@
>      if (!$pid) {
>          # this is the child process, fork another process to run a manager.
>          defined(my $pid = fork) or die;
> +        my $logging = $suppress_logs ? "| tee $manager_log_file"
> +                                     : "> $manager_log_file 2>&1";

Do you want "2>&1 | tee $manager_log_file" for the first alternative? That sends both stdout and stderr through tee.
Attachment #8412991 - Flags: review?(n.nethercote) → review+
Assignee

Updated

5 years ago
Attachment #8412991 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/bb50d61e7777
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.