1001703 - Remove memswap wrapping

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Description

[Mike Hommey [:glandium]]

memswap was removed in bionic in
https://android.googlesource.com/platform/bionic/+/152b9de19ade833ada124390ef153e53d3d3e2ed

This breaks loading libmozglue on systems that have that bionic version (so, likely, an upcoming release), and building with the upcoming x86_64 NDK.

We're not using it anywhere in gecko code, so it's safe to remove the wrapper. (See bug 791419 as to where they come from)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Remove memswap wrapping

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8413010 [details] [diff] [review]
Remove memswap wrapping

Review of attachment 8413010 [details] [diff] [review]:
-----------------------------------------------------------------

Do you know why we had it in the first place? Were we using it in b2g?

Comment 3

[Mike Hommey [:glandium]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #2)
> Do you know why we had it in the first place? Were we using it in b2g?

The list was derived from a list of all weak symbols in Kindle Fire HD's libc. It never was related to what we're using.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3b2c106d5ec2

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3b2c106d5ec2