Closed Bug 1001703 Opened 10 years ago Closed 10 years ago

Remove memswap wrapping

Categories

(Core :: mozglue, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

memswap was removed in bionic in
https://android.googlesource.com/platform/bionic/+/152b9de19ade833ada124390ef153e53d3d3e2ed

This breaks loading libmozglue on systems that have that bionic version (so, likely, an upcoming release), and building with the upcoming x86_64 NDK.

We're not using it anywhere in gecko code, so it's safe to remove the wrapper. (See bug 791419 as to where they come from)
Attachment #8413010 - Flags: review?(snorp)
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Comment on attachment 8413010 [details] [diff] [review]
Remove memswap wrapping

Review of attachment 8413010 [details] [diff] [review]:
-----------------------------------------------------------------

Do you know why we had it in the first place? Were we using it in b2g?
Attachment #8413010 - Flags: review?(snorp) → review+
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #2)
> Do you know why we had it in the first place? Were we using it in b2g?

The list was derived from a list of all weak symbols in Kindle Fire HD's libc. It never was related to what we're using.
https://hg.mozilla.org/mozilla-central/rev/3b2c106d5ec2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.