1002077 - contentprefs service uses the non-existent nsIFrameMessageListener interface

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[(no longer active)]

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/contentprefs/nsContentPrefService.js#75

Comment 1

[Drew Willcoxon :adw]

Attachment: de-electrolify

It looks like nsIFrameMessageListener changed to nsIMessageListener while I was working on bug 699859, and my patches still applied cleanly, and I didn't notice.  You can see the change in the obsolete patches there.

Bug 777196 removed most of the e10s code, including the receiveMessage definition, so CPS1 doesn't actually implement nsIMessageListener anyway.

Actually, none of the remaining e10s code is necessary anymore either I think.  (It was added in bug 584842.)  Nobody is creating the service in content anymore, so electrolify's check for that isn't necessary, and nobody is sending ContentPref:{set,get}Pref messages from content anymore, so the category in the manifest isn't necessary.  Finally, nobody is using CPS.wrappedJSObject, so electrolify can go away entirely.

https://tbpl.mozilla.org/?tree=Try&rev=e266cdf4dd8d

Comment 2

[Drew Willcoxon :adw]

Try results are good.

Comment 3

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/fx-team/rev/b04759a8cbde

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b04759a8cbde

Comment 5

[Marco Mucci [:MarcoM]]

Hi Juan, can you review to determine if this bug requires further QA verification.