Closed
Bug 1002077
Opened 10 years ago
Closed 10 years ago
contentprefs service uses the non-existent nsIFrameMessageListener interface
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
VERIFIED
FIXED
mozilla32
People
(Reporter: ehsan.akhgari, Assigned: adw)
References
Details
(Whiteboard: p=2 s=it-32c-31a-30b.1 [qa-])
Attachments
(1 file)
2.99 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•10 years ago
|
||
It looks like nsIFrameMessageListener changed to nsIMessageListener while I was working on bug 699859, and my patches still applied cleanly, and I didn't notice. You can see the change in the obsolete patches there. Bug 777196 removed most of the e10s code, including the receiveMessage definition, so CPS1 doesn't actually implement nsIMessageListener anyway. Actually, none of the remaining e10s code is necessary anymore either I think. (It was added in bug 584842.) Nobody is creating the service in content anymore, so electrolify's check for that isn't necessary, and nobody is sending ContentPref:{set,get}Pref messages from content anymore, so the category in the manifest isn't necessary. Finally, nobody is using CPS.wrappedJSObject, so electrolify can go away entirely. https://tbpl.mozilla.org/?tree=Try&rev=e266cdf4dd8d
Assignee | ||
Comment 2•10 years ago
|
||
Try results are good.
Updated•10 years ago
|
Attachment #8415654 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b04759a8cbde
OS: Mac OS X → All
Hardware: x86 → All
Updated•10 years ago
|
Whiteboard: p=2 s=it-32c-31a-30b.1
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b04759a8cbde
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Comment 5•10 years ago
|
||
Hi Juan, can you review to determine if this bug requires further QA verification.
Flags: needinfo?(jbecerra)
Flags: firefox-backlog+
Whiteboard: p=2 s=it-32c-31a-30b.1 → p=2 s=it-32c-31a-30b.1 [qa?]
Updated•10 years ago
|
Flags: needinfo?(jbecerra)
Whiteboard: p=2 s=it-32c-31a-30b.1 [qa?] → p=2 s=it-32c-31a-30b.1 [qa-]
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•