1002184 - (Gloa:LongNamesStats) Long Country Names In Graph Can Overlap Data

Status: RESOLVED FIXED

(Websites :: glow.mozilla.org, defect)

Description

[Ben (:bensternthal)]

Attachment: Screen Shot 2014-04-27 at 11.44.44 AM.png

Long country names used as labels can override the stats. See screenshot.

Comment 1

[Ali Almossawi]

It wasn't a problem with English with our 500 share data threshold, but it might just be safer to increase the width of the area where the country names appear. Will push the change in a bit.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mrburns

https://github.com/mozilla/mrburns/commit/e6694e7e493cafa1c4dafa7267e4d00198b98700
Fix bug #1002184

Stats chart 3 long country names overlap chart

https://github.com/mozilla/mrburns/commit/a5c69569f72c412c7031819521e79e4fd3a35838
Merge pull request #157 from almossawi/master

Fix bug #1002184

Comment 3

[Ali Almossawi]

The change is in dev, kindly verify.

Comment 4

[Ben (:bensternthal)]

Attachment: Screenshot_2014-04-27-12-08-39.png

Looks ok on desktop but I can still reproduce on mobile.

Comment 5

[Ali Almossawi]

Comment on attachment 8413414 [details]
Screenshot_2014-04-27-12-08-39.png

The screenshot appears to show the original, possibly cached, version of the chart. Can you try again with a cleared cache and report if the issue persists, as I'm unable to reproduce it anymore on either mobile or desktop.

Comment 6

[Ben (:bensternthal)]

Just tested Dev. You are correct this looks good.