Closed Bug 1002264 Opened 10 years ago Closed 10 years ago

[System] Remove System.publish function

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)

People

(Reporter: kgrandon, Assigned: kgrandon)

Details

(Whiteboard: [systemsfe],[p=1])

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review 
System.js has a publish function that is only used once. I think it makes sense to remove this and just use the typical CustomEvent pattern.
Attached file Github pull request — 

    
    

    
  
Comment on attachment 8413447 [details] [review]
Github pull request

Hey Alive - what do you think?

        Attachment #8413447 -
        Flags: review?(alive)
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S1 (9may)

        Attachment #8413447 -
        Flags: review?(alive) → review+

    
    

    
  
Thanks for the review! Landed: https://github.com/mozilla-b2g/gaia/commit/6c6f82d1cece112c1d8918cfc980fbd8d4ba1482
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe] → [systemsfe],[p=1]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: