1002278 - Location Bar is missing on current trunk

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, defect)

Description

[Ian Neal]

Using current trunk (m-c ea25086073c8, c-c 62d03039a718) is missing the location bar from the browser window. The error console has the following error in:
Error: NS_NOINTERFACE: 
Source File: chrome://global/content/bindings/browser.xml
Line: 516

Reverting back to build from 26th April (m-c 93a71ca8b150, c-c b940fa424367) gives a visible location bar.

Build based on m-c eadb8b61b59a and c-c 62d03039a718 is missing the location bar too.
Potential cause bug 959209.

Comment 1

[Philip Chee]

(In reply to [e-mail] from Bug 959209 comment #18)
> Comment on attachment 8413173 [details] [diff] [review]
> mozilla-central patch
> 
> >+/* SeaMonkey don't use the new toolkit's autocomplete widget yet.... */
> >+%ifdef MOZ_SUITE
> > %define AUTOCOMPLETE_OLD_STYLE
> > %endif
> > 
> > %ifdef AUTOCOMPLETE_OLD_STYLE
> Bah, I meant to say that you should eliminate the AUTOCOMPLETE_OLD_STYLE
> variable.

Comment 2

[Magnus Melin [:mkmelin]]

Ugh, probably the bridge/bridge.mozbuild change in attachment 8413171 [details] [diff] [review]? That should probably still exist, with 

if CONFIG['MOZ_SUITE']

Comment 3

[[e-mail]]

Actually we could probably add to suite/app.mozbuild something like

add_tier_dir('app', '/xpfe/components/autocomplete')

Comment 4

[Robert Kaiser]

Looks like the addressing widget in mailcompose is broken as well, I guess it's the same cause as it should have autocomplete as well.

Comment 5

[Philip Chee]

Attachment: Patch v1.0 Add xpfe autocomplete to tier_app

Comment 6

[Robert Kaiser]

Comment on attachment 8413752 [details] [diff] [review]
Patch v1.0 Add xpfe autocomplete to tier_app

Review of attachment 8413752 [details] [diff] [review]:
-----------------------------------------------------------------

I can confirm that this patch fixes both the address bar and the mailnews compose addressing widget.

Comment 7

[[e-mail]]

Comment on attachment 8413752 [details] [diff] [review]
Patch v1.0 Add xpfe autocomplete to tier_app

Wasn't KaiRo a build peer at one point? ;-)

Comment 8

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/a184d0a8e93c