1002300 - Lazily create the backbuffer for ContentClientDoubleBuffered

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Bas Schouten (:bas.schouten)]

Attachment: Only lazily create our backbuffer

Right now we create a front buffer when we create the backbuffer, but it will only be used as an actual back buffer if the layer is actually changed. This patch makes it so we only lazily create a backbuffer. This seems to even make the code a little cleaner in my opinion.

I think this is correct, but this code is such a mess it's hard to be 100% sure. This might even save us memory where buffer rotation is used with non-changing layers.

Comment 1

[Bas Schouten (:bas.schouten)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96395ad2aac9

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/96395ad2aac9

Comment 3

[Ed Morley [:emorley]]

Bas, please could you back this out asap, since this caused bug 1014355 - and we haven't had a response from you in that bug in the last 10 days. I'd rather investigate this once we've backed out, to reduce the number of failures the sheriffs are having to deal with. Thanks!

Comment 4

[Ed Morley [:emorley]]

Milan, we're struggling to get a response from Bas in order to back this bug out for causing bug 1014355. We haven't had a single reply since the needinfo on 2014-05-30 in bug 1014355 comment 46. Please can you see what's up? Thanks!

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Bas, with bug 1014355 assigned, but not knowing how long it will take to fix, what are the implications of backing this out?

Comment 6

[Bas Schouten (:bas.schouten)]

The implications of backing this out is regressing performance for static pageloads on B2G and Windows with Direct2D. I don't think it's worth it.