Closed Bug 1002325 Opened 6 years ago Closed 6 years ago
crash in ns
Pres Context::Rebuild User Font Set()
This bug was filed from the Socorro interface and is report bp-71c75c57-0b82-46c4-833c-19bf52140420. ============================================================= New crash on nightly starting 18th April. null nsPresContext here: xul!nsPresContext::RebuildUserFontSet xul!nsUserFontSet::DoRebuildUserFontSet xul!gfxUserFontSet::RebuildLocalRules xul!RebuildLocalFonts xul!nsTHashtable<nsUint64HashKey>::s_EnumStub xul!PL_DHashTableEnumerate xul!nsTHashtable<nsPtrHashKey<gfxUserFontSet> >::EnumerateEntries xul!gfxPlatformFontList::UpdateFontList xul!gfxWindowsPlatform::UpdateFontList xul!nsThebesFontEnumerator::UpdateFontList xul!nsWindow::ProcessMessage This code was added in bug 964613.
Looks like a simple null-check should be sufficient here. mPresContext should never be null -except- when the font set is destined for deletion, in which case we no longer care about rebuilding rules.
Attachment #8413613 - Flags: review?(jdaggett)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/mozilla-inbound/rev/293ecda82136 I suggest we leave this bug open until we've had a few days on Nightly to confirm that the crashes go away.
Whiteboard: [leave open]
Target Milestone: --- → mozilla32
No crashes on nightly since the 5/1 build.
Comment on attachment 8413613 [details] [diff] [review] don't try to rebuild rules if the font set is being deleted. [Approval Request Comment] Bug caused by (feature/regressing bug #): 964613 User impact if declined: sporadic crashiness on pages that use webfonts Testing completed (on m-c, etc.): several days on nightly since patch landed, no crash reports seen Risk to taking this patch (and alternatives if risky): minimal risk String or IDL/UUID changes made by this patch: none
Attachment #8413613 - Flags: approval-mozilla-aurora?
(In reply to David Major [:dmajor] (UTC+12) from comment #4) > No crashes on nightly since the 5/1 build. Thanks for following up; marking this fixed on trunk.
Attachment #8413613 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to David Major [:dmajor] (UTC+12) from comment #4) > No crashes on nightly since the 5/1 build. Confirmed
You need to log in before you can comment on or make changes to this bug.