Closed Bug 1002377 Opened 6 years ago Closed 6 years ago

[Stingray] A template for the homescreen-stingray app

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lchang, Assigned: lchang)

References

Details

(Whiteboard: [FT:Stream3])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
jj.evelyn
: review+
johnhu
: review+
Details | Review
Creating a template for the homescreen-stingray app could make further works easier.
Attached file Pull Request 18734
Hi Evelyn and John, 

Would you mind reviewing this simple patch? Thanks.
Attachment #8413620 - Flags: review?(johu)
Attachment #8413620 - Flags: review?(ehung)
Should we put test/* with this PR?
Updated! I've put "test/unit/setup.js" in this patch.
Comment on attachment 8413620 [details] [review]
Pull Request 18734

Cool!... Let's kick off it.
Attachment #8413620 - Flags: review?(johu) → review+
No longer blocks: 1002336
Comment on attachment 8413620 [details] [review]
Pull Request 18734

I've left some comments on your PR. Please address them. I'd like to take a look before landing, please flag review again when you're done. Thanks.
Attachment #8413620 - Flags: review?(ehung)
Comment on attachment 8413620 [details] [review]
Pull Request 18734

Hi Evelyn, I've addressed them. Please help to review it again. Thanks.
Attachment #8413620 - Flags: review+ → review?(ehung)
Comment on attachment 8413620 [details] [review]
Pull Request 18734

Hi John, Sorry to clear your review flag by mistake. I'm setting it back.
Attachment #8413620 - Flags: review?(johu)
Comment on attachment 8413620 [details] [review]
Pull Request 18734

Looks good to me, except one nit - I hope we can add a comment on js/vendor/evt.js to describe it's a copy from camera app with a few modifications. Thanks!
Attachment #8413620 - Flags: review?(ehung) → review+
Attachment #8413620 - Flags: review?(johu) → review+
(In reply to Evelyn Hung [:evelyn] from comment #8)
> Looks good to me, except one nit - I hope we can add a comment on
> js/vendor/evt.js to describe it's a copy from camera app with a few
> modifications. Thanks!

Evelyn, thanks. I've added a comment to leave the footprint for that. Besides, I also removed our modifications in order to make it consistent with its source and easier to be moved to shared library.
travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/24425637

merged in gaia v1.3t branch:
https://github.com/mozilla-b2g/gaia/commit/26506219bb0513dcacb7cb93aac63f0080ce61be
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
(In reply to Luke Chang [:lchang] from comment #10)
> merged in gaia v1.3t branch:
> https://github.com/mozilla-b2g/gaia/commit/26506219bb0513dcacb7cb93aac63f0080ce61be

Sorry, it's in gaia master branch, not v1.3t.
Whiteboard: [FT:Stream3]
You need to log in before you can comment on or make changes to this bug.