1002377 - [Stingray] A template for the homescreen-stingray app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Luke Chang [:lchang] (inactive)]

Creating a template for the homescreen-stingray app could make further works easier.

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request 18734

Hi Evelyn and John, 

Would you mind reviewing this simple patch? Thanks.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Should we put test/* with this PR?

Comment 3

[Luke Chang [:lchang] (inactive)]

Updated! I've put "test/unit/setup.js" in this patch.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8413620 [details] [review]
Pull Request 18734

Cool!... Let's kick off it.

Comment 5

[Evelyn Hung]

Comment on attachment 8413620 [details] [review]
Pull Request 18734

I've left some comments on your PR. Please address them. I'd like to take a look before landing, please flag review again when you're done. Thanks.

Comment 6

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8413620 [details] [review]
Pull Request 18734

Hi Evelyn, I've addressed them. Please help to review it again. Thanks.

Comment 7

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8413620 [details] [review]
Pull Request 18734

Hi John, Sorry to clear your review flag by mistake. I'm setting it back.

Comment 8

[Evelyn Hung]

Comment on attachment 8413620 [details] [review]
Pull Request 18734

Looks good to me, except one nit - I hope we can add a comment on js/vendor/evt.js to describe it's a copy from camera app with a few modifications. Thanks!

Comment 9

[Luke Chang [:lchang] (inactive)]

(In reply to Evelyn Hung [:evelyn] from comment #8)
> Looks good to me, except one nit - I hope we can add a comment on
> js/vendor/evt.js to describe it's a copy from camera app with a few
> modifications. Thanks!

Evelyn, thanks. I've added a comment to leave the footprint for that. Besides, I also removed our modifications in order to make it consistent with its source and easier to be moved to shared library.

Comment 10

[Luke Chang [:lchang] (inactive)]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/24425637

merged in gaia v1.3t branch:
https://github.com/mozilla-b2g/gaia/commit/26506219bb0513dcacb7cb93aac63f0080ce61be

Comment 11

[Luke Chang [:lchang] (inactive)]

(In reply to Luke Chang [:lchang] from comment #10)
> merged in gaia v1.3t branch:
> https://github.com/mozilla-b2g/gaia/commit/26506219bb0513dcacb7cb93aac63f0080ce61be

Sorry, it's in gaia master branch, not v1.3t.