Closed Bug 1002406 Opened 10 years ago Closed 10 years ago

[Tarako][Bluetooth] Pairing dialog(attention screen) cannot be close after run on monkey test

Categories

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3T+)

RESOLVED WORKSFORME
blocking-b2g 1.3T+

People

(Reporter: iliu, Assigned: iliu)

Details

Attachments

(3 files)

=== STR ===:
Run the build on monkey test.

=== Actual Result ===
Bluetooth pairing dialog cannot be close.

=== Expected Result ===
Even if the pairing process is unsuccessful, the pairing dialog should be closed normally. 

=== Build ===:
ro.build.version.incremental=eng.kaizhen.20140425.155902
ro.build.date=Fri Apr 25 15:59:09 CST 2014
Status: NEW → ASSIGNED
Triage. 1.3T+
blocking-b2g: 1.3T? → 1.3T+
Attached file WIP 18739
* Check module is existed or not before call the method.

This is a WIP. And will request review after run on monkey test normally.
Kai-Zhe, could you please help to run monkey test with the WIP?
Flags: needinfo?(kli)
OK, it will be included in 04/29 monkey test.
Flags: needinfo?(kli)
Any update?
Flags: needinfo?(kli)
Tim, monkey test was failed due to another error in kernel. So not sure if attachment 8413671 [details] [review] fix the problem. There will be a 6 hours result this evening and a 12 hours result on tomorrow morning. I'll update the result then.
Flags: needinfo?(kli)
6 hours test is finished, 3/3 device passed the test. All devices do work properly after test.
14 hours test is also finished, 3/3 devices didn't hit this error.
Kai-Zhen, thanks for your verification. Per offline discussion, I just rebase my patch. If we wonder that the patch is not relative with the issue. We might run the monkey test again without my patch. Then, we observer that issue is able to be reproduced.
Ian, 24 hours test is also finished. It's still not reproduced. 
If the patch is only doing good but no side effect, I think we should land it. 
How do you think?
Flags: needinfo?(iliu)
Comment on attachment 8413671 [details] [review]
WIP 18739

Kai-Zhen, thanks for your test with patience. I also agree with your suggestion since the patch is very low risk.

Nominate Arthur to be reviewer because he has reviewed the module before. Arthur, could you please help to review my pr? I add some check before call these function. Thanks.
Attachment #8413671 - Flags: review?(arthur.chen)
Flags: needinfo?(iliu)
Comment on attachment 8413671 [details] [review]
WIP 18739

Is there any log supporting the patch? I was thinking the problem might only due to the racing between loading "bluetooth_helper.js" and "pair_manager.js".
Attachment #8413671 - Flags: review?(arthur.chen)
Per offline discussion with Kai-Zhen, the daily monkey test is not including of WIP here after 5/6. It means that the issue is no longer to be reproduced without any updated patch recently. I would like to change the bug status to be work for me. But, we can reopen it while the issue is able to reproduce again.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: