1002421 - [Tarako][Email]Attachment exceeds 1MB, file name and warning string will overlap

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Mike Lien[:mlien]]

Attachment: 2014-04-28-18-57-32.png

[Device]
  Tarako
---------------------------------------------
[Reproduction build] - 0417pac + PVT v1.3T
  Gaia      8895b180ed636069473703d0e7b73086989601ce
  Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/7caf4b5abfce
  BuildID   20140428014001
  Version   28.1
---------------------------------------------
[Reproduce Steps]
  1. Launch Email app
  2. Verify any mail contains attachment which file size exceeds 1MB
---------------------------------------------
[Expected Result]
  See file name and warning string clearly
---------------------------------------------
[Actual Result]
  file name and warning string will overlap
---------------------------------------------
[Reproduce Rate]
  100%

Comment 1

[Marcus Cavanaugh [:mcav]]

Ah. As I mentioned in Bug 996232, the Tarako uplift required different CSS which didn't get uplifted when sprd-ffos decided to uplift the patch themselves to 1.3t.

Comment 2

[Marcus Cavanaugh [:mcav]]

Attachment: Pull Request

Comment 3

[Marcus Cavanaugh [:mcav]]

Attachment: Fixed Screenshot

Comment 4

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8413888 [details] [review]
Pull Request

As I mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=996232#c30 , the uplift of Bug 996232 required different CSS than the master patch. When it was uplifted without warning, the CSS it included was incorrect.

This patch adjusts the offsets so that the message displays in the proper position on 1.3t. With this patch, up to two lines of the attachment warning are legible; a third line would overflow the attachment box but I don't think that will actually show up in practice.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8413888 [details] [review]
Pull Request

Hooray for easy reviews thanks to screenshots!  (And the people who provide them.  The screenshots, that is.)

Comment 6

[Keven Kuo [:kkuo]]

Hi! James,

Check in needed. Thanks.

--
Keven

Comment 7

[Carsten Book [:Tomcat]]

Master - https://github.com/mozilla-b2g/gaia/commit/3d297f7d9481e5b71c1eaa6e952f5d7e0b61de28

Comment 8

[James Zhang (Spreadtrum)]

(In reply to Keven Kuo [:kkuo] from comment #6)
> Hi! James,
> 
> Check in needed. Thanks.
> 
> --
> Keven

Loop Yang.

Comment 9

[yang.zhao]

(In reply to Carsten Book [:Tomcat] from comment #7)
> Master -
> https://github.com/mozilla-b2g/gaia/commit/
> 3d297f7d9481e5b71c1eaa6e952f5d7e0b61de28

Hi,did you write wrong branch?I found the link you added is for v1.3t.

Comment 10

[yang.zhao]

(In reply to James Zhang from comment #8)
> (In reply to Keven Kuo [:kkuo] from comment #6)
> > Hi! James,
> > 
> > Check in needed. Thanks.
> > 
> > --
> > Keven
> 
> Loop Yang.
The link in comment #7 is for v1.3t.
So mozilla already land it on v1.3t.

Comment 11

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Verified fixed in today's build


1.3t Environmental Variables:
Device: Tarako 1.3t
BuildID: 20140429014002
Gaia: b5adc5a943d3abbd6ab070a47c847f2c24891cc5
Gecko: e9890f5d4709
Version: 28.1
Firmware Version: sp6821

Comment 12

[Edward Chen[:edchen]]

Verified by comment 11, I marked it to "VERIFIED"

(In reply to dharris from comment #11)
> Verified fixed in today's build
> 
> 
> 1.3t Environmental Variables:
> Device: Tarako 1.3t
> BuildID: 20140429014002
> Gaia: b5adc5a943d3abbd6ab070a47c847f2c24891cc5
> Gecko: e9890f5d4709
> Version: 28.1
> Firmware Version: sp6821