Closed Bug 1002435 Opened 10 years ago Closed 10 years ago

Build ICU with UCONFIG_NO_IDNA

Categories

(Firefox Build System :: General, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

(Keywords: memory-footprint)

Attachments

(1 file)

We don't use the ICU IDNA implementation, so we shouldn't ship it as dead code. Therefore, we should build with UCONFIG_NO_IDNA=1.
Comment on attachment 8413709 [details] [diff] [review]
Fix

The B2G red on try is unrelated to this patch. The red in because of earlier stuff in my queue interacting badly with unified builds.

This appears to make opt libxul smaller by 192 KB on Linux x86_64. The reduction seems unbelievably significant, but I guess it's good that this change has some impact.
Attachment #8413709 - Flags: review?(mh+mozilla)
Attachment #8413709 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/9ff13ffd5f25
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Depends on: 1005176
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.