Closed Bug 1002437 Opened 10 years ago Closed 10 years ago

Build ICU with U_CHARSET_IS_UTF8

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(1 file)

We aren't supposed to be using ICU in a way where ICU would interact with non-UTF-8 char* system APIs. In order to make ICU smaller, we should build with U_CHARSET_IS_UTF8.
Comment on attachment 8413712 [details] [diff] [review]
Fix

Disappointingly, this seems to save only 55 bytes in Linux x86_64 libxul size.

Since the patch is already here and the reduction is non-zero, requesting review anyway.
Attachment #8413712 - Flags: review?(mh+mozilla)
Attachment #8413712 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/72215f1d9de0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Depends on: 1005176
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.