Closed
Bug 1002437
Opened 12 years ago
Closed 12 years ago
Build ICU with U_CHARSET_IS_UTF8
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file)
|
1.36 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
We aren't supposed to be using ICU in a way where ICU would interact with non-UTF-8 char* system APIs. In order to make ICU smaller, we should build with U_CHARSET_IS_UTF8.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 8413712 [details] [diff] [review]
Fix
Disappointingly, this seems to save only 55 bytes in Linux x86_64 libxul size.
Since the patch is already here and the reduction is non-zero, requesting review anyway.
Attachment #8413712 -
Flags: review?(mh+mozilla)
|
||
Updated•12 years ago
|
Attachment #8413712 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•