1002459 - [Dialer] Unexpected "Hold" text appearing over the "Hold" icon

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Noemí Freire (:noemi)]

Attachment: 2014-04-28-09-15-36.png

Pre-requisites:
* Call waiting active

STRs:
1- Establish a call
2- Having a call established, receive an incoming call

ACTUAL:
A chinese text is appearing over the "Hold" icon

EXPECTED:
Only the "Hold" icon should be shown

Environmental variables:
Device: Hamachi
BuildId: 2010'428065258
Gecko: de552d3
Gaia: b641571
Platform version: 31.0a1

Comment 1

[Noemí Freire (:noemi)]

It is working fine on today's (4/28) v1.4 build:
Device: Hamachi
BuildId: 2010428053154
Gecko: 1d45d07
Gaia: d23e479
Platform version: 30.0a2

regression so setting blocking-b2g flag accordingly

Comment 2

[Jason Smith [:jsmith]]

Does this occur on Tarako?

Comment 3

[Harvey]

This issue does NOT occur on the latest Tarako 1.3t

The accept call button appears as expected without any overlapping characters.

1.3t Environmental Variables:
Device: Tarako 
BuildID: 20140428032258
Gaia: 99d36ea9325d8112e78c0f19ef64c71441e91b92
Gecko: b78345f8f52f
Version: 28.1
Firmware Version: sp6821a-4-18

Comment 4

[Harvey]

B2G Inbound Regression Window

Last Working:
Environmental Variables:
Device: Buri
BuildID: 20140402123132
Gaia: 039037c16948c0985f6779886fac595b111979f4
Gecko: e7b7bdbffe2b
Version: 31.0a1
Firmware Version: v1.2-device.cfg

First Broken:
Environmental Variables:
Device: Buri
BuildID: 20140402130133
Gaia: 208d70961b6e3f615b9195d9558157bf7b1fdd28
Gecko: ba30e8f5d6b4
Version: 31.0a1
Firmware Version: v1.2-device.cfg

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 208d70961b6e3f615b9195d9558157bf7b1fdd28
Gecko: e7b7bdbffe2b

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 039037c16948c0985f6779886fac595b111979f4
Gecko: ba30e8f5d6b4

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/039037c16948c0985f6779886fac595b111979f4...208d70961b6e3f615b9195d9558157bf7b1fdd28

Comment 5

[Jason Smith [:jsmith]]

Caused by bug 923139.

Yura - Can you take a look?

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

It's related to bug 994702, I changed all languages there but then was suggested to only change the English message bundle.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Yura Zenevich [:yzen] from comment #6)
> It's related to bug 994702, I changed all languages there but then was
> suggested to only change the English message bundle.

Rik is out, so I'll ask that question to Etienne.

Etienne - Why wasn't the other locales updated here? The bug here shows this not working in non-en US locales.

Comment 8

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

Hi Fernando, tiny tiny review :)

(In reply to Jason Smith [:jsmith] from comment #7)
> Etienne - Why wasn't the other locales updated here? The bug here shows this
> not working in non-en US locales.

Don't know, here's a patch.

Comment 9

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/f55fc5c507312c7aac51ec9bb73061fd4ed5c5fb

Comment 10

[Loli (:lolimartinezcr)]

Tested and working
1.5
Hamachi
Gecko: 6fafefc
Gaia: 0d705e6