1002571 - Implement ServiceWorkerContainer.getRegistrations() and ServiceWorkerContainer.getRegistration()

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Comment 1

[Andrea Marchesini [:baku]]

GetAll has been renamed to getRegistrations

Comment 2

[Andrea Marchesini [:baku]]

Attachment: getRegistrations.patch

Comment 3

[Andrea Marchesini [:baku]]

Attachment: getRegistrations.patch

This new patch implements both getRegistration and getRegistrations

Comment 4

[Andrea Marchesini [:baku]]

Attachment: getRegistrations.patch

tests updated.

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8469214 [details] [diff] [review]
getRegistrations.patch

Review of attachment 8469214 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/ServiceWorkerManager.cpp
@@ +585,5 @@
> +    }
> +
> +    for (uint32_t i = 0; i < domainInfo->mOrderedScopes.Length(); ++i) {
> +      nsresult rv = principal->CheckMayLoad(docURI, true /* report */,
> +                                            false /* allowIfInheritsPrinciple */);

I don't understand this, principal and docURI are derived from the same document.

@@ +592,5 @@
> +      }
> +
> +      nsRefPtr<ServiceWorkerRegistration> swr =
> +        new ServiceWorkerRegistration(mWindow,
> +                                      NS_ConvertUTF8toUTF16(domainInfo->mOrderedScopes[i]));

Indentation.

@@ +629,5 @@
> +
> +  nsCOMPtr<nsIURI> documentURI = window->GetDocumentURI();
> +  if (!documentURI) {
> +    return NS_ERROR_FAILURE;
> +  }

This entire block in unnecessary when the runnable deals with it, correct?

@@ +735,5 @@
> +
> +  nsCOMPtr<nsIURI> documentURI = window->GetDocumentURI();
> +  if (!documentURI) {
> +    return NS_ERROR_FAILURE;
> +  }

This entire block in unnecessary when the runnable deals with it, correct?

Comment 6

[Andrea Marchesini [:baku]]

Attachment: getRegistrations.patch

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Do you have a link to a recent try run handy for this patch before we check it in?

Comment 8

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Here is one with the patch https://tbpl.mozilla.org/?tree=Try&rev=28d7624a47fe
The related mochitests are actually disabled on non-windows platforms, so it should be ok to take this.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e77f258cee0b

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e77f258cee0b