Closed
Bug 1002600
Opened 7 years ago
Closed 7 years ago
Intermittent dom/mobilemessage/tests/test_mms_pdu_helper.js | Test timed out
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(firefox31 unaffected, firefox32 fixed, firefox33 fixed, firefox-esr24 unaffected, b2g-v1.3 unaffected, b2g-v1.3T unaffected, b2g-v1.4 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)
RESOLVED
FIXED
2.0 S5 (4july)
Tracking | Status | |
---|---|---|
firefox31 | --- | unaffected |
firefox32 | --- | fixed |
firefox33 | --- | fixed |
firefox-esr24 | --- | unaffected |
b2g-v1.3 | --- | unaffected |
b2g-v1.3T | --- | unaffected |
b2g-v1.4 | --- | fixed |
b2g-v2.0 | --- | fixed |
b2g-v2.1 | --- | fixed |
People
(Reporter: RyanVM, Assigned: vicamo)
References
Details
(Keywords: intermittent-failure, Whiteboard: [p=1])
Attachments
(1 file, 1 obsolete file)
22.97 KB,
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=38630765&tree=B2g-Inbound b2g_emulator_vm b2g-inbound opt test xpcshell on 2014-04-28 06:48:30 PDT for push ac5d447ee498 slave: tst-linux64-spot-966 06:56:45 INFO - TEST-INFO | /builds/slave/test/build/tests/xpcshell/tests/dom/mobilemessage/tests/test_mms_pdu_helper.js | running test ... 07:01:45 WARNING - TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/xpcshell/tests/dom/mobilemessage/tests/test_mms_pdu_helper.js | Test timed out 07:01:46 INFO - TEST-PASS | /builds/slave/test/build/tests/xpcshell/tests/dom/mobilemessage/tests/test_mms_pdu_helper.js | test passed (time: 300695.828ms)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 3•7 years ago
|
||
Many of the MMS PDU encoder/decoder tests use for-loop to try every possible case. We have 24 such for loops and each of them iterates 256 times, so we have 6K test runs introduced by these loops. By checking edge conditions instead, the tests slimmed down to around 1/25, and total execution time is shorten from 15s to 6s.
Attachment #8443883 -
Flags: review?(gene.lian)
Assignee | ||
Comment 4•7 years ago
|
||
b2g emulator xpcshell try run: https://tbpl.mozilla.org/?tree=Try&rev=ca583bdb366d
Comment 5•7 years ago
|
||
Comment on attachment 8443883 [details] [diff] [review] bug-1002600-intermittent-test_mms_pdu_helper.patch Review of attachment 8443883 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me but could you add some simple comment in the codes for why you use these specific numbers?
Attachment #8443883 -
Flags: review?(gene.lian) → review+
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Gene Lian [:gene] (business trip Jun. 16 ~ Jun. 20) from comment #5) > Looks good to me but could you add some simple comment in the codes for why > you use these specific numbers? They're boundary numbers. For example, usually we have valid codes 128 & 129, so I test 0, 1, 127, 128, 129, 130, and 255.
Comment 7•7 years ago
|
||
Yes, I know. Just hope you can add some comment for this intention so that others can follow you when looking at the codes. ;)
Assignee | ||
Comment 8•7 years ago
|
||
Add comments for those magic numbers used.
Attachment #8443883 -
Attachment is obsolete: true
Attachment #8444994 -
Flags: review+
Assignee | ||
Comment 9•7 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/c1c7f1d83dc3
Comment 10•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c1c7f1d83dc3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•7 years ago
|
status-b2g-v1.3:
--- → unaffected
status-b2g-v1.3T:
--- → unaffected
status-b2g-v1.4:
--- → unaffected
status-b2g-v2.0:
--- → affected
status-b2g-v2.1:
--- → fixed
status-firefox31:
--- → unaffected
status-firefox32:
--- → affected
status-firefox33:
--- → fixed
status-firefox-esr24:
--- → unaffected
Assignee | ||
Comment 11•7 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/ccadb30f49c3
Assignee | ||
Comment 12•7 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d5c726affb05
Reporter | ||
Updated•7 years ago
|
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•