1002600 - Intermittent dom/mobilemessage/tests/test_mms_pdu_helper.js | Test timed out

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=38630765&tree=B2g-Inbound

b2g_emulator_vm b2g-inbound opt test xpcshell on 2014-04-28 06:48:30 PDT for push ac5d447ee498
slave: tst-linux64-spot-966

06:56:45     INFO -  TEST-INFO | /builds/slave/test/build/tests/xpcshell/tests/dom/mobilemessage/tests/test_mms_pdu_helper.js | running test ...
07:01:45  WARNING -  TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/xpcshell/tests/dom/mobilemessage/tests/test_mms_pdu_helper.js | Test timed out
07:01:46     INFO -  TEST-PASS | /builds/slave/test/build/tests/xpcshell/tests/dom/mobilemessage/tests/test_mms_pdu_helper.js | test passed (time: 300695.828ms)

Comment 1

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=41335949&tree=Mozilla-B2g30-v1.4
b2g_emulator_vm mozilla-b2g30_v1_4 debug test xpcshell on 2014-06-08 21:42:35
revision: 841035112e1e
slave: tst-linux64-spot-153

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/xpcshell/tests/dom/mobilemessage/tests/test_wsp_pdu_helper.js | Test timed out
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/xpcshell/tests/dom/mobilemessage/tests/test_mms_pdu_helper.js | Test timed out

Comment 2

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=41497804&tree=Mozilla-Inbound
b2g_emulator_vm mozilla-inbound debug test xpcshell on 2014-06-10 20:05:29
revision: 04569d6f8799
slave: tst-linux64-spot-084

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/xpcshell/tests/dom/mobilemessage/tests/xpcshell/test_mms_pdu_helper.js | Test timed out

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Attachment: bug-1002600-intermittent-test_mms_pdu_helper.patch

Many of the MMS PDU encoder/decoder tests use for-loop to try every possible case.  We have 24 such for loops and each of them iterates 256 times, so we have 6K test runs introduced by these loops. By checking edge conditions instead, the tests slimmed down to around 1/25, and total execution time is shorten from 15s to 6s.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

b2g emulator xpcshell try run: https://tbpl.mozilla.org/?tree=Try&rev=ca583bdb366d

Comment 5

[Gene Lian (I already quit Mozilla)]

Comment on attachment 8443883 [details] [diff] [review]
bug-1002600-intermittent-test_mms_pdu_helper.patch

Review of attachment 8443883 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me but could you add some simple comment in the codes for why you use these specific numbers?

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Gene Lian [:gene] (business trip Jun. 16 ~ Jun. 20) from comment #5)
> Looks good to me but could you add some simple comment in the codes for why
> you use these specific numbers?

They're boundary numbers.  For example, usually we have valid codes 128 & 129, so I test 0, 1, 127, 128, 129, 130, and 255.

Comment 7

[Gene Lian (I already quit Mozilla)]

Yes, I know. Just hope you can add some comment for this intention so that others can follow you when looking at the codes. ;)

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch : v2

Add comments for those magic numbers used.

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/c1c7f1d83dc3

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c1c7f1d83dc3

Comment 11

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/ccadb30f49c3

Comment 12

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d5c726affb05

Comment 13

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=7059092
repository: mozilla-inbound
start_time: 2015-02-27T09:48:52
who: rvandermeulen[at]mozilla[dot]com
machine: tst-linux64-spot-121
buildname: b2g_emulator_vm mozilla-inbound debug test xpcshell-1
revision: d4516fac0a6f

TEST-UNEXPECTED-TIMEOUT | dom/mobilemessage/tests/xpcshell/test_mms_pdu_helper.js | Test timed out
TEST-UNEXPECTED-FAIL | Received SIGINT (control-C), so stopped run. (Use --keep-going to keep running tests after killing one with SIGINT)
Automation Error: Exception caught while running tests
Return code: 1

Comment 14

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=2067311
repository: b2g-inbound
start_time: 2015-06-02T11:44:45
who: rvandermeulen[at]mozilla[dot]com
machine: tst-linux64-spot-1357
buildname: b2g_emulator_vm b2g-inbound debug test xpcshell-1
revision: c046d7b76f2f

TEST-UNEXPECTED-TIMEOUT | dom/mobilemessage/tests/xpcshell/test_mms_pdu_helper.js | Test timed out
TEST-UNEXPECTED-FAIL | Received SIGINT (control-C), so stopped run. (Use --keep-going to keep running tests after killing one with SIGINT)
Automation Error: Exception caught while running tests
Return code: 1