Closed Bug 1002658 Opened 10 years ago Closed 10 years ago

E-mail application sends IMAP password for SMTP


(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Not set


(Not tracked)

2.0 S1 (9may)


(Reporter: rlb, Assigned: mcav)



(3 files)

46 bytes, text/x-github-pull-request
: review+
Details | Review
55 bytes, text/x-github-pull-request
: review+
Details | Review
56 bytes, text/x-github-pull-request
: review+
Details | Review
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0 Iceweasel/28.0 (Beta/Release)
Build ID: 20140319130652

Steps to reproduce:

I attempted to set up an email acount which requires different IMAP and SMTP servers (with different passwords), which fortunately, the UI now allows.

Actual results:

It appears that the IMAP password is being sent to the SMTP server.  I'ver verifed this by enabling postfix's debug_peer_list which allows me to capture the base64 encoded value sent from the phone.  Decoding it reveals the IMAP password, not the SMTP password.

Expected results:

The phone should have sent the SMTP password to the SMTP server.
The phone is a nexus-s running a recent, locally-built
Assignee: nobody → m
Ever confirmed: true
Target Milestone: --- → 2.0 S1 (9may)
Attached file Gaia PR
Attached file mail-fakeservers PR
Comment on attachment 8413972 [details] [review]
mail-fakeservers PR

This passes credentials.outgoingPassword through to the fake server so that we can have tests that start with the right data.
Attachment #8413972 - Flags: review?(bugmail)
Comment on attachment 8413971 [details] [review]
Gaia PR

As discussed on IRC, we had previously passed outgoingPassword in the wrong place. This adds a marionette test that tries to complete manual setup with a different password, which required a small patch to mail-fakeservers.

Travis will probably scoff at the missing NPM dependency, so if you want to review mail-fakeservers first and wait for me to make sure Travis passes, that's cool.
Attachment #8413971 - Flags: review?(bugmail)
Attachment #8413972 - Flags: review?(bugmail) → review+
Comment on attachment 8413971 [details] [review]
Gaia PR

Thanks for the super-fast turnaround!  This offsets your super-fast bit-rotting of some cleanup I did to mail-fakeservers on :asuth's current never-ending-never-landing bug. ;)

I trust you to get the node-modules situation in hand.  Please make sure you follow Hub's directions from 4/1/2014 to dev-gaia though so we don't experience wacky backouts (if it hasn't been documented elsewhere).
Attachment #8413971 - Flags: review?(bugmail) → review+
Attached file gaia-node-modules PR
Attachment #8414047 - Flags: review?(kgrandon)
Comment on attachment 8414047 [details] [review]
gaia-node-modules PR

Didn't test it, but will gladly review-stamp it - just make sure travis is green before merging to gaia master. Note: I'm currently working on enabling updates for gaia-node-modules in bug 1001224 (so please don't land before that).
Attachment #8414047 - Flags: review?(kgrandon) → review+
You need to log in before you can comment on or make changes to this bug.