1002658 - E-mail application sends IMAP password for SMTP

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Rob Browning]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0 Iceweasel/28.0 (Beta/Release)
Build ID: 20140319130652

Steps to reproduce:

I attempted to set up an email acount which requires different IMAP and SMTP servers (with different passwords), which fortunately, the UI now allows.


Actual results:

It appears that the IMAP password is being sent to the SMTP server.  I'ver verifed this by enabling postfix's debug_peer_list which allows me to capture the base64 encoded value sent from the phone.  Decoding it reveals the IMAP password, not the SMTP password.


Expected results:

The phone should have sent the SMTP password to the SMTP server.

Comment 1

[Rob Browning]

The phone is a nexus-s running a recent, locally-built 1.5.0.0-prerelease.

Comment 2

[Marcus Cavanaugh [:mcav]]

Attachment: Gaia PR

Comment 3

[Marcus Cavanaugh [:mcav]]

Attachment: mail-fakeservers PR

Comment 4

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8413972 [details] [review]
mail-fakeservers PR

This passes credentials.outgoingPassword through to the fake server so that we can have tests that start with the right data.

Comment 5

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8413971 [details] [review]
Gaia PR

As discussed on IRC, we had previously passed outgoingPassword in the wrong place. This adds a marionette test that tries to complete manual setup with a different password, which required a small patch to mail-fakeservers.

Travis will probably scoff at the missing NPM dependency, so if you want to review mail-fakeservers first and wait for me to make sure Travis passes, that's cool.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8413971 [details] [review]
Gaia PR

Thanks for the super-fast turnaround!  This offsets your super-fast bit-rotting of some cleanup I did to mail-fakeservers on :asuth's current never-ending-never-landing bug. ;)

I trust you to get the node-modules situation in hand.  Please make sure you follow Hub's directions from 4/1/2014 to dev-gaia though so we don't experience wacky backouts (if it hasn't been documented elsewhere).

Comment 7

[Marcus Cavanaugh [:mcav]]

Attachment: gaia-node-modules PR

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8414047 [details] [review]
gaia-node-modules PR

Didn't test it, but will gladly review-stamp it - just make sure travis is green before merging to gaia master. Note: I'm currently working on enabling updates for gaia-node-modules in bug 1001224 (so please don't land before that).

Comment 9

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia-node-modules/commit/e2363f2015312426fe8845ce890d199d785437f1

Comment 10

[Marcus Cavanaugh [:mcav]]

mail-fakeservers: https://github.com/mozilla-b2g/mail-fakeservers/commit/26733f4d4914a20b3f28d343811bbeb39b763316

master: https://github.com/mozilla-b2g/gaia/commit/8cf0972c2929a558e8bab702629e7d446a1777e5