1002708 - Add-on SDK ui-button module picks different icons from list provided by the add-on when in customize mode the first time vs. the second time (possibly OS X hidpi related)

Status: RESOLVED WORKSFORME

(Add-on SDK Graveyard :: General, defect, P1)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

This can be tested with the Lightbeam add-on on OS X.
When Lightbeam is in the customization palette, its icon is being shown after a fresh start of the browser. However, if you just exit and re-enter customization mode, it doesn't display the icon anymore (just the text). The icon then remains hidden until the next restart of the browser.

On Windows 8.1, the icon is always visible (as it should be).

Comment 1

[:Gijs (he/him)]

Does lightbeam show the default "add-on" icon, or does it have its own icon (in the version you're using)?

Comment 2

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to :Gijs Kruitbosch (PTO april 28) from comment #1)
> Does lightbeam show the default "add-on" icon, or does it have its own icon
> (in the version you're using)?

It has its own icon. It's version 1.0.9.

Comment 3

[:Gijs (he/him)]

I hope to be able to look at this in the coming week. Not sure I actually will, however...

Comment 4

[:Gijs (he/him)]

Does this reproduce with any other add-ons? It looks like the icon changes from the 32x32 to 48x48, which isn't in their repo and therefore isn't shipped. Needinfo'ing Monica for that, because it looks like it does claim this is usable, and that's weird: https://github.com/mozilla/lightbeam/blob/master/lib/ui.js#L277

However, it's also strange that at one point, the SDK decides to use one icon, and at another point, it randomly decides to use a different one. Matteo, can you look at this, please?

Comment 5

[[:mmc] Monica Chew (no longer reading bugmail)]

Gijs, thanks for finding that bug. We'll remove reference to that icon in the next release, which should hopefully be out next week.

Comment 6

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to :Gijs Kruitbosch from comment #4)
> Does this reproduce with any other add-ons?
I do have a similar issue with Adblock edge (https://addons.mozilla.org/sv-SE/firefox/addon/adblock-edge/), but it is not exactly the same since it just never shows an icon when in the customization palette.

Comment 7

[:Gijs (he/him)]

(In reply to Philipp Sackl [:phlsa] from comment #6)
> (In reply to :Gijs Kruitbosch from comment #4)
> > Does this reproduce with any other add-ons?
> I do have a similar issue with Adblock edge
> (https://addons.mozilla.org/sv-SE/firefox/addon/adblock-edge/), but it is
> not exactly the same since it just never shows an icon when in the
> customization palette.

I'll try and have a look what's up here in the near future, but I'm pretty backlogged because of high-prio other stuff.

Comment 8

[Matteo Ferretti [:zer0] [:matteo]]

(In reply to :Gijs Kruitbosch from comment #4)

> However, it's also strange that at one point, the SDK decides to use one
> icon, and at another point, it randomly decides to use a different one.
> Matteo, can you look at this, please?

I'll take a look on that.

Comment 9

[:Gijs (he/him)]

The ABE case is because it references "abe-status-32.png" which doesn't actually exist in the add-on (unlike abe-status.png, abe-status-16.png and abe-icon-big.png).

Sounds like all that remains is the SDK issue.

Comment 10

[Erik Vold [:erikvold] (please needinfo? me)]

Hey Matteo, are you working on this one? if not could you please unassign yourself.

Comment 11

[Matteo Ferretti [:zer0] [:matteo]]

Sorry, I wasn't working on SDK anymore; and it gets a lower priority since WebExt. I tried to take a look but I wasn't able to reproduce the issue (on OS X). Please, feel free to reopen the bug if it's still applicable.