1002831 - Show SDP on about:webrtc

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Byron Campen [:bwc]]

It would be useful to show the SDP on about:webrtc; this is not shown explicitly in r_log, so it is pretty inconvenient to work out what it probably was.

Comment 1

[Byron Campen [:bwc]]

Attachment: Display remote and local SDP on about:webrtc

Initial cut.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8417529 [details] [diff] [review]
Display remote and local SDP on about:webrtc

Review of attachment 8417529 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. It's starting to look a bit unruly. We should probably add expand/contract arrows next, so we can minimize all this to regain overview and let people dig into the PC they want info on.

Comment 3

[Byron Campen [:bwc]]

Agreed. I'm not a webby kind of person, so I don't know off the top of my head how to do this though. We might have some canned solution that about:memory uses.

Comment 4

[Byron Campen [:bwc]]

Needinfo myself to check back on try push. Note also that this patch will only apply cleanly when the final reports patch from 970734 is applied, although they don't have any dependency relationship.

https://tbpl.mozilla.org/?tree=Try&rev=843c1c533287

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

(In reply to Byron Campen [:bwc] from comment #3)
> Agreed. I'm not a webby kind of person, so I don't know off the top of my
> head how to do this though.

I was thinking we'd use the <details> tag http://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_details

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Duh, try in firefox first. :-(

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

That's Bug 591737

Comment 8

[Byron Campen [:bwc]]

Try looks good. Requesting checkin; be aware that 970734 part 2 should be checked in first, or else you'll get bitrot.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

A DOM peer needs to review the WebIDL changes before this can land.

Comment 10

[Byron Campen [:bwc]]

Again, make sure to land after bug 970734 part 2, or else the patch will not apply cleanly.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc5a50413848

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fc5a50413848