Closed Bug 1002831 Opened 6 years ago Closed 6 years ago

Show SDP on about:webrtc

Categories

(Core :: WebRTC: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: bwc, Assigned: bwc)

References

Details

(Whiteboard: [p=3, ft:webrtc])

Attachments

(1 file)

It would be useful to show the SDP on about:webrtc; this is not shown explicitly in r_log, so it is pretty inconvenient to work out what it probably was.
Assignee: nobody → docfaraday
Initial cut.
Attachment #8417529 - Flags: review?(jib)
Comment on attachment 8417529 [details] [diff] [review]
Display remote and local SDP on about:webrtc

Review of attachment 8417529 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. It's starting to look a bit unruly. We should probably add expand/contract arrows next, so we can minimize all this to regain overview and let people dig into the PC they want info on.
Attachment #8417529 - Flags: review?(jib) → review+
Agreed. I'm not a webby kind of person, so I don't know off the top of my head how to do this though. We might have some canned solution that about:memory uses.
Needinfo myself to check back on try push. Note also that this patch will only apply cleanly when the final reports patch from 970734 is applied, although they don't have any dependency relationship.

https://tbpl.mozilla.org/?tree=Try&rev=843c1c533287
Flags: needinfo?(docfaraday)
(In reply to Byron Campen [:bwc] from comment #3)
> Agreed. I'm not a webby kind of person, so I don't know off the top of my
> head how to do this though.

I was thinking we'd use the <details> tag http://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_details
Duh, try in firefox first. :-(
Try looks good. Requesting checkin; be aware that 970734 part 2 should be checked in first, or else you'll get bitrot.
Flags: needinfo?(docfaraday)
Keywords: checkin-needed
A DOM peer needs to review the WebIDL changes before this can land.
Keywords: checkin-needed
Attachment #8417529 - Flags: review?(bugs)
Attachment #8417529 - Flags: review?(bugs) → review+
Again, make sure to land after bug 970734 part 2, or else the patch will not apply cleanly.
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.