1002929 - mozilla::pkix::der::GeneralizedTime uses implicit conversion from der::Result to boolean

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: no-implicit-conversion.patch

Comment 1

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8414231 [details] [diff] [review]
no-implicit-conversion.patch

Review of attachment 8414231 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Another thought: should we change the memcmp in Input::Expect to not do an implicit conversion? (i.e. "if (memcmp(input, expected, expectedLen) != 0)" on/around line 101)

Comment 2

[[:mmc] Monica Chew (no longer reading bugmail)]

(In reply to David Keeler (:keeler) from comment #1)
> Another thought: should we change the memcmp in Input::Expect to
> not do an implicit conversion? (i.e. "if (memcmp(input, expected,
> expectedLen) != 0)" on/around line 101)

I think implicit conversion between int and bool is ok (desired, even).

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to [:mmc] Monica Chew (please use needinfo) from comment #2)
> I think implicit conversion between int and bool is ok (desired, even).

I agree for memcmp at least.

Thanks for the review.

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8cb84a2584f

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f8cb84a2584f