Closed
Bug 1003086
Opened 11 years ago
Closed 10 years ago
[DSDS][Fugu][Buri]"Not imported" shown under "SIM card" in Contacts, after importing contacts in FTU
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(b2g-v1.4 verified, b2g-v2.0 verified, b2g-v2.1 verified, b2g-v2.2 verified)
VERIFIED
FIXED
2.1 S1 (1aug)
People
(Reporter: ericcc, Assigned: hola)
Details
Attachments
(2 files)
### Version Fugu v1.4 GAIA_REV=d23e479e8a4ce0bc620acb2d7e2f82801aa4d0ea GECKO_REV=1d45d07b59c6bb9262e8f47db9d491d9a9f8b21b BUILD_TAG=jenkins-B2G.v1.4.0.fugu-35 BuildID=20140428041552 Buri v2.0 Gaia cadddcac2b8ce162a5e27e6dc105557b00a94478 Gecko https://hg.mozilla.org/mozilla-central/rev/b681a6daea3b BuildID 20140428160200 Version 32.0a1 ### STR 1. SIMs with contacts stored in them. 2. Flash phones. 3. Enter FTU. 4. Import contacts from SIM. 5. Open Contacts -> Settings -> Import Contacts ### Actual 6. "Not imported" under "SIM card".
Reporter | ||
Comment 1•11 years ago
|
||
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(francisco)
Comment 3•10 years ago
|
||
No it's not, but I think this is a bug caused for the separation of the FTU from communications. Unfortunately there is no easy solution, right now we were saving when we were performing the import in indexedDB and we won't be able to share that information anymore. The first, quick and very dirty solution that comes to my mind is to use settings (both applications have access to settings), to save this information. Jose, any thoughs?
Flags: needinfo?(francisco) → needinfo?(jmcf)
Comment 4•10 years ago
|
||
We can apply the same solution we did for Facebook, whoch is using IAC to notify Contacts from FTU when the operation has been done. Assigning to Marina as she will be solving this.
Assignee: nobody → mri
Flags: needinfo?(jmcf)
Comment 5•10 years ago
|
||
IAC for this... I rather remove the functionality. Seriously, in Tarako we are going to launch contacts during the ftu to do this, and I've seen already a bug about being OOMK in FTU when importing contacts. IMHO, is way to much. Just saying that we landed a communication between FTU and Contacts to pass FB tokens, again that's way too much, we rather go through something lighter. Could we move this to DS, since DS is certified, once it's open for priviledge sure we have a mechanism to assing access permissions between apps. Please dont use IAC for such a tiny thing.
Comment 6•10 years ago
|
||
(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #5) > IAC for this... I rather remove the functionality. Seriously, in Tarako we > are going to launch contacts during the ftu to do this, and I've seen > already a bug about being OOMK in FTU when importing contacts. > Well, Tarako has v1.3T and not master, thus I don't see any problem right now. > IMHO, is way to much. Just saying that we landed a communication between FTU > and Contacts to pass FB tokens, again that's way too much, we rather go > through something lighter. We did it that way because it minimized the changes on the Contacts App which has been clearly a quick win. On the other hand we need to notify the Contacts App to schedule the next sync for Facebook data. If you do this with the Datastore only that sync will only be scheduled if Contacts App is open which might introduce a potential bug. > > Could we move this to DS, since DS is certified, once it's open for > priviledge sure we have a mechanism to assing access permissions between > apps. > There is no problem in communication between apps that cannot be solved by using Datastores, but why do we have the IAC mechanism as well? Because there are use cases that can benefit from its existence. > Please dont use IAC for such a tiny thing. I disagree.
Comment 7•10 years ago
|
||
(In reply to Jose Manuel Cantera from comment #6) > > > > Could we move this to DS, since DS is certified, once it's open for > > priviledge sure we have a mechanism to assing access permissions between > > apps. > > > > There is no problem in communication between apps that cannot be solved by > using Datastores, but why do we have the IAC mechanism as well? Because > there are use cases that can benefit from its existence. If we use IAC for communicating we will be launching a new process, even if we load a path that doesn't include a lot of JS, just the overhead of the process will be > 4MB. That to me is enough reason to try to see if it's a better mechanism. > > > Please dont use IAC for such a tiny thing. > > I disagree. :) well, we cannot always agree. Cheers.
Comment 8•10 years ago
|
||
(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #7) > (In reply to Jose Manuel Cantera from comment #6) > > > > > > Could we move this to DS, since DS is certified, once it's open for > > > priviledge sure we have a mechanism to assing access permissions between > > > apps. > > > > > > > There is no problem in communication between apps that cannot be solved by > > using Datastores, but why do we have the IAC mechanism as well? Because > > there are use cases that can benefit from its existence. > > If we use IAC for communicating we will be launching a new process, even if > we load a path that doesn't include a lot of JS, just the overhead of the > process will be > 4MB. > > That to me is enough reason to try to see if it's a better mechanism. We could even delay the IAC call until the end of the FTU, i.e. by the time the contacts app is run the FTU would have terminated. > > > > > > Please dont use IAC for such a tiny thing. > > > > I disagree. > > :) well, we cannot always agree. lol > > Cheers.
Reporter | ||
Comment 9•10 years ago
|
||
Flame central v2.1 reproducible Gaia d29773d2a011825fd77d1c0915a96eb0911417b6 Gecko https://hg.mozilla.org/mozilla-central/rev/4024d8019701 BuildID 20140716160202 Version 33.0a1 ro.build.version.incremental=109 ro.build.date=Mon Jun 16 16:51:29 CST 2014 B1TC00011220
blocking-b2g: --- → 2.1?
status-b2g-v1.4:
--- → affected
status-b2g-v2.0:
--- → affected
status-b2g-v2.1:
--- → affected
Comment 11•10 years ago
|
||
I definitely agree that if contacts are imported at FTU, contact setting should reflect it. ni Contact UX owner Carrie to comment on this.
Flags: needinfo?(jelee) → needinfo?(cawang)
Comment 12•10 years ago
|
||
Yes, looks like a bug here. Let's wait for the fix. Thanks.
Flags: needinfo?(cawang)
Updated•10 years ago
|
Assignee: mri → hola
Comment 14•10 years ago
|
||
Comment on attachment 8464547 [details]
22246.html
Fernando,
Please could you do a quick review for the FTU part?
thanks
Attachment #8464547 -
Flags: review?(jmcf)
Attachment #8464547 -
Flags: review?(fernando.campo)
Attachment #8464547 -
Flags: review+
Updated•10 years ago
|
Target Milestone: --- → 2.1 S1 (1aug)
Comment 15•10 years ago
|
||
Comment on attachment 8464547 [details]
22246.html
FTU part looks good, nice change for datastores :)
Attachment #8464547 -
Flags: review?(fernando.campo) → review+
Comment 16•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/e554e48e95f2af0816be13a0976a3899c4545ec0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 17•10 years ago
|
||
Works fine with v2.1 Gaia 19bf9795263e2ccc15d824a52ebf23c2670fa9b9 Gecko https://hg.mozilla.org/mozilla-central/rev/7f81be7db528 BuildID 20140804160542 Version 34.0a1 ro.build.version.incremental=109 ro.build.date=Mon Jun 16 16:51:29 CST 2014 B1TC00011220 Q: it reads SIM1 only, right? or both? Since we don't have separate label for each sim under "Import contacts" in FTU..
Status: RESOLVED → VERIFIED
Flags: needinfo?(jmcf)
Updated•10 years ago
|
Flags: needinfo?(jmcf)
Comment 18•10 years ago
|
||
Adrian, Plase could respond to Eric's question. thanks
Flags: needinfo?(hola)
Assignee | ||
Comment 19•10 years ago
|
||
As you state, FTU only reads from the main SIM, and saves the timestamp with the id of that SIM to make it work as expected with contacts app.
Flags: needinfo?(hola)
Updated•10 years ago
|
blocking-b2g: 2.1? → ---
Comment 20•10 years ago
|
||
This has been verified fixed on Flame 2.2 (319mb)(Kitkat Base)(Shallow Flash), Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash), Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash) and Flame 1.4 (319mb)(Jelly Bean)(Shallow Flash) Result: It shows "Imported TODAY" plus timestamp Environmental Variables: Device: Flame 2.2 (319mb)(Kitkat Base)(Shallow Flash) Build ID: 20141126040207 Gaia: 41b7be7c67167f367c3c4982ff08651d55455373 Gecko: 7bcc6573d204 Version: 36.0a1 Firmware Version: v188-1 User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0 ---------------------------------------------------------------------------------------------------------------- Environmental Variables: Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash) BuildID: 20141126001202 Gaia: db2e84860f5a7cc334464618c6ea9e92ff82e9dd Gecko: 211eae88f119 Version: 34.0 Firmware Version: v188-1 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 ----------------------------------------------------------------------------------------------------------------- Environmental Variables: Device: Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash) Build ID: 20141126000203 Gaia: f9d6e3d83c3922e9399a6c27f5ce4cdd27bdfd05 Gecko: 45112935086f Version: 32.0 Firmware Version: v188-1 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 ------------------------------------------------------------------------------------------------------------------- Environmental Variables: Device: Flame 1.4 (319mb)(Jelly Bean)(Shallow Flash) BuildID: 20141126000201 Gaia: 22c80a708329321a2fdeed4ece019498c0cec90d Gecko: 429d90dd383c Version: 30.0 Firmware: V123 User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.2:
--- → verified
Flags: needinfo?(ktucker)
Keywords: verifyme
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•