1003168 - xpcshell/head.js:359 - TypeError: _log_message_with_stack is not a function

Status: RESOLVED INCOMPLETE

(Testing :: XPCShell Harness, defect)

Description

[Ed Morley [:emorley]]

It looks like the error logging added in bug isn't working?
https://tbpl.mozilla.org/php/getParsedLog.php?id=38709201&tree=Fx-Team

{
06:30:08     INFO -  TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/search/tests/xpcshell/head_search.js | "afterCache: init-complete"
06:30:08     INFO -  TOPIC: browser-search-service
06:30:08     INFO -  *** Search: _asyncInit: Completed _asyncInit
06:30:08  WARNING -  TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/search/tests/xpcshell/test_nocache.js | false == true - See following stack:
06:30:08     INFO -  JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/search/tests/xpcshell/test_nocache.js :: ss_initialized :: line 45
06:30:08     INFO -  JS frame :: resource://gre/components/nsSearchService.js :: onSuccess :: line 3708
06:30:08     INFO -  JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Handler.prototype.process :: line 863
06:30:08     INFO -  JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.walkerLoop :: line 742
06:30:08     INFO -  JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/head.js :: _do_main :: line 176
06:30:08     INFO -  JS frame :: /builds/slave/talos-slave/test/build/tests/xpcshell/head.js :: _execute_test :: line 389
06:30:08     INFO -  JS frame :: -e :: <TOP_LEVEL> :: line 1
06:30:08     INFO -  native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
06:30:08     INFO -  TEST-INFO | (xpcshell/head.js) | exiting test
06:30:08     INFO -  !!! error running onStopped callback: TypeError: callback is not a function
06:30:08     INFO -  System JS : ERROR /builds/slave/talos-slave/test/build/tests/xpcshell/head.js:359 - TypeError: _log_message_with_stack is not a function
06:30:08     INFO -  [4388] WARNING: Leaking the RDF Service.: file /builds/slave/fx-team-osx64-d-00000000000000/build/rdf/build/nsRDFModule.cpp, line 165
06:30:08     INFO -  [4388] WARNING: '!compMgr', file /builds/slave/fx-team-osx64-d-00000000000000/build/xpcom/glue/nsComponentManagerUtils.cpp, line 59
06:30:08     INFO -  [4388] WARNING: OOPDeinit() without successful OOPInit(): file /builds/slave/fx-team-osx64-d-00000000000000/build/toolkit/crashreporter/nsExceptionHandler.cpp, line 2553
06:30:08     INFO -  [4388] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/slave/fx-team-osx64-d-00000000000000/build/xpcom/base/nsTraceRefcnt.cpp, line 142
06:30:08     INFO -  [4388] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/slave/fx-team-osx64-d-00000000000000/build/xpcom/base/nsTraceRefcnt.cpp, line 142
06:30:08     INFO -  nsStringStats
06:30:08     INFO -   => mAllocCount:           3418
06:30:08     INFO -   => mReallocCount:          335
06:30:08     INFO -   => mFreeCount:            3418
06:30:08     INFO -   => mShareCount:           9249
06:30:08     INFO -   => mAdoptCount:            160
06:30:08     INFO -   => mAdoptFreeCount:        160
06:30:08     INFO -   => Process ID: 4388, Thread ID: 140735176860032
06:30:08     INFO -  <<<<<<<
}

The TypeError comes from:
http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/head.js#358
{
353   _Promise.Debugging.clearUncaughtErrorObservers();
354   _Promise.Debugging.addUncaughtErrorObserver(function observer({message, date, fileName, stack, lineNumber}) {
355     let text = "Once bug 976205 has landed, THIS ERROR WILL CAUSE A TEST FAILURE.\n" +
356         " A promise chain failed to handle a rejection: " +
357         message + " - rejection date: " + date;
358     _log_message_with_stack("test_known_fail",
359                             text, stack, fileName);
360   });
}

The original failure that is triggering that log output is a bad checkin in:
https://tbpl.mozilla.org/?tree=Fx-Team&rev=77abda00ae6e

David, don't suppose you could take a look? :-)

Comment 1

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley UTC+0] from comment #0)
> It looks like the error logging added in bug 

Bug 995198 that is.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Mmmh... The function seems to be executed in a context in which _log_message_with_stack is undefined. I have seen weird stuff with xpcshell losing its scope during bailout in case of errors, and I believe that it's the same issue, applied to a new kind of error.

I hope that bug 996652 will fix this class of issues.

Comment 3

[Ed Morley [:emorley]]

Mean to say - thank you for taking a look :-)

Comment 4

[Ed Morley [:emorley]]

Mass-closing old bugs I filed that have not had recent activity/no longer affect me.