1003228 - Remove unnecessary APZ-related settings and menu items

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Now that APZ in Gaia is turned on and here to stay, we can clean up some of the settings and stuff we put in to fiddle with it.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Remove some developer settings

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Remove the sleep menu APZ-toggle

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Github PR

Oh whoops, I should just link to the PR instead. 3 commits there.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Note to self: update https://developer.mozilla.org/en-US/Firefox_OS/Debugging/Developer_settings once this lands.

Comment 5

[[:fabrice] Fabrice Desré]

Kats, please request uplifts on 1.3/1.4 too. thanks!

Comment 6

[Jan Keromnes [:janx]]

Kats, I remember about a thread on dev-gaia where Chris Mills talked about updating that same devmoz page to reflect FxOS 2.0 changes: https://groups.google.com/d/msg/mozilla.dev.gaia/1Z0F9v8gBBw/kUqz1zhWAkEJ

Maybe you should sync up with him on the effort?

Comment 7

[Francesco Lodolo [:flod]]

(In reply to Fabrice Desré [:fabrice] from comment #5)
> Kats, please request uplifts on 1.3/1.4 too. thanks!

Please don't remove the strings from .properties file in those two, that will create unnecessary noise in tools (it's still breaking string freeze).

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8414544 [details] [review]
Github PR

I'm trying to redirect all those devtools related things to Janx! Jan, please tell me if you feel uncomfortable, or come to my desk if there is anything in the PR that is out of your comfort zone.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

(In reply to Jan Keromnes [:janx] from comment #6)
> Kats, I remember about a thread on dev-gaia where Chris Mills talked about
> updating that same devmoz page to reflect FxOS 2.0 changes:
> https://groups.google.com/d/msg/mozilla.dev.gaia/1Z0F9v8gBBw/kUqz1zhWAkEJ
> 
> Maybe you should sync up with him on the effort?

Sure, I can chime in there.

Comment 10

[Jan Keromnes [:janx]]

Comment on attachment 8414544 [details] [review]
Github PR

Looks good to me! r+ with nits:

Please remove the asyncpanzoom and asyncpanzoomOff entries in: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/locales/system.en-US.properties#L63-L64

Please also clean up the gecko part in a follow-up:
- http://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#603-633 and related pref-dependent code if the pref aren't used anymore.
- http://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#669 and related pref if not used anymore.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Attachment: Gecko-side patch

I updated the pull request with the thing you pointed out above, and changed the r= as well. Here is the gecko-side patch.

Comment 12

[Jan Keromnes [:janx]]

Comment on attachment 8417571 [details] [diff] [review]
Gecko-side patch

Review of attachment 8417571 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for cleaning up this code as well!

::: b2g/chrome/content/settings.js
@@ -665,5 @@
>      defaultValue: false
>    },
>    'layers.enable-tiles': true,
>    'layers.simple-tiles': false,
> -  'layers.progressive-paint': true,

Warning: I believe this entry is currently "false" in master, maybe you have a local patch forcing it to true?

Comment 13

[Jan Keromnes [:janx]]

Comment on attachment 8414544 [details] [review]
Github PR

Thanks for addressing my nits!

Comment 14

[Kartikaya Gupta (email:[e-mail])]

(In reply to Jan Keromnes [:janx] from comment #12)
> >    'layers.simple-tiles': false,
> > -  'layers.progressive-paint': true,
> 
> Warning: I believe this entry is currently "false" in master, maybe you have
> a local patch forcing it to true?

Oh good point, I do. I'll make sure to fix that when I land it.

Comment 15

[Jan Keromnes [:janx]]

Comment on attachment 8414544 [details] [review]
Github PR

(declaring as patch in order to checkin+)

Comment 16

[Kartikaya Gupta (email:[e-mail])]

janx kindly merged the gaia changes:

https://github.com/mozilla-b2g/gaia/compare/c49a054b78f0...4b354dfa48dc

Once these changes get propagated to m-c and inbound I'll land the gecko half, so that we don't have any intermediate states with broken settings.

Comment 17

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4094a0e89ed3

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4094a0e89ed3