Remove unnecessary APZ-related settings and menu items

RESOLVED FIXED in 2.0 S1 (9may)

Status

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
2.0 S1 (9may)
All
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Now that APZ in Gaia is turned on and here to stay, we can clean up some of the settings and stuff we put in to fiddle with it.
Posted file Github PR
Oh whoops, I should just link to the PR instead. 3 commits there.
Attachment #8414541 - Attachment is obsolete: true
Attachment #8414542 - Attachment is obsolete: true
Attachment #8414541 - Flags: review?(21)
Attachment #8414542 - Flags: review?(21)
Attachment #8414544 - Flags: review?(21)
Kats, please request uplifts on 1.3/1.4 too. thanks!
Kats, I remember about a thread on dev-gaia where Chris Mills talked about updating that same devmoz page to reflect FxOS 2.0 changes: https://groups.google.com/d/msg/mozilla.dev.gaia/1Z0F9v8gBBw/kUqz1zhWAkEJ

Maybe you should sync up with him on the effort?
Flags: needinfo?(bugmail.mozilla)
(In reply to Fabrice Desré [:fabrice] from comment #5)
> Kats, please request uplifts on 1.3/1.4 too. thanks!

Please don't remove the strings from .properties file in those two, that will create unnecessary noise in tools (it's still breaking string freeze).
Comment on attachment 8414544 [details] [review]
Github PR

I'm trying to redirect all those devtools related things to Janx! Jan, please tell me if you feel uncomfortable, or come to my desk if there is anything in the PR that is out of your comfort zone.
Attachment #8414544 - Flags: review?(21) → review?(janx)
(In reply to Jan Keromnes [:janx] from comment #6)
> Kats, I remember about a thread on dev-gaia where Chris Mills talked about
> updating that same devmoz page to reflect FxOS 2.0 changes:
> https://groups.google.com/d/msg/mozilla.dev.gaia/1Z0F9v8gBBw/kUqz1zhWAkEJ
> 
> Maybe you should sync up with him on the effort?

Sure, I can chime in there.
Flags: needinfo?(bugmail.mozilla)
Comment on attachment 8414544 [details] [review]
Github PR

Looks good to me! r+ with nits:

Please remove the asyncpanzoom and asyncpanzoomOff entries in: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/locales/system.en-US.properties#L63-L64

Please also clean up the gecko part in a follow-up:
- http://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#603-633 and related pref-dependent code if the pref aren't used anymore.
- http://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#669 and related pref if not used anymore.
Attachment #8414544 - Flags: review?(janx) → review+
I updated the pull request with the thing you pointed out above, and changed the r= as well. Here is the gecko-side patch.
Attachment #8417571 - Flags: review?(janx)
Comment on attachment 8417571 [details] [diff] [review]
Gecko-side patch

Review of attachment 8417571 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for cleaning up this code as well!

::: b2g/chrome/content/settings.js
@@ -665,5 @@
>      defaultValue: false
>    },
>    'layers.enable-tiles': true,
>    'layers.simple-tiles': false,
> -  'layers.progressive-paint': true,

Warning: I believe this entry is currently "false" in master, maybe you have a local patch forcing it to true?
Attachment #8417571 - Flags: review?(janx) → review+
Comment on attachment 8414544 [details] [review]
Github PR

Thanks for addressing my nits!
(In reply to Jan Keromnes [:janx] from comment #12)
> >    'layers.simple-tiles': false,
> > -  'layers.progressive-paint': true,
> 
> Warning: I believe this entry is currently "false" in master, maybe you have
> a local patch forcing it to true?

Oh good point, I do. I'll make sure to fix that when I land it.
Comment hidden (obsolete)
(Assignee)

Comment 16

5 years ago
landing
janx kindly merged the gaia changes:

https://github.com/mozilla-b2g/gaia/compare/c49a054b78f0...4b354dfa48dc

Once these changes get propagated to m-c and inbound I'll land the gecko half, so that we don't have any intermediate states with broken settings.
Attachment #8414544 - Attachment is patch: false
Attachment #8414544 - Attachment mime type: text/plain → text/x-github-pull-request
https://hg.mozilla.org/mozilla-central/rev/4094a0e89ed3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
You need to log in before you can comment on or make changes to this bug.