Closed Bug 1003244 Opened 6 years ago Closed 3 years ago

Creation of csv file attachement on new Mozilla Reps Swag Request

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: couci, Assigned: dylan)

Details

Attachments

(3 files, 1 obsolete file)

Attached file swagform.csv
In light of our new  collaboration with Staples, I'm requesting the creation of a new csv file attachement at every Mozilla Reps Swag Request. Please use the csv template attached.
I've used {{ when the info needed is been extracted from the fields of the swag form.
On the field on the recipient name field, please use the name that is given in shipping details section.
Let me know if you need any more info.

Thanks in advance
Assignee: nobody → glob
hi :couci,

is this a replacement for the existing xml attachment, or an additional attachment?
Flags: needinfo?(konstantina)
Hey Bryon,
this is an additional attachment

thanks
Flags: needinfo?(konstantina)
Assignee: glob → dylan
The first column, "Date Required", is that the "Ship Before" date on the form? Also, the last column, "Notes", should that be populated?
My last question: What should go into the "Item" columns? There are 14 of them, do they map to the checkboxes on the swag form or are they just there for padding?

Thanks!
Status: NEW → ASSIGNED
Flags: needinfo?(konstantina)
Hey Dylan thanks for following up
replies are in line
(In reply to Dylan William Hardison [:dylan] from comment #3)
> The first column, "Date Required", is that the "Ship Before" date on the
> form?
Yes it's the same thing
 Also, the last column, "Notes", should that be populated?
Yes we would like to add there the info from "Addition information for delivery person" on the form
> My last question: What should go into the "Item" columns? There are 14 of
> them, do they map to the checkboxes on the swag form or are they just there
> for padding?
the items columns will be filled in by me manually (we change item codes a lot) so you don't need to worry about them, just leave them blank 
> 
> Thanks!

thanks a lot!
Flags: needinfo?(konstantina)
Alright, form is up and ready to test on bugzilla-dev: https://bugzilla-dev.allizom.org/form:reps:swag

There are no form fields correspending to Mozilla Space, Team, or Department Code. Those are currently hard coded to examples given in the attached csv - is that correct?

Also, there is no "shiptoemail", so both email columns are identical -- that is probably not right. Please test out of the form on https://bugzilla-dev.allizom.org/form:reps:swag and let me know what changes are required.

Thanks!
Flags: needinfo?(konstantina)
Attached patch bug-1003244.patch (obsolete) — Splinter Review
Patch for review
Attachment #8438745 - Flags: review?(glob)
Comment on attachment 8438745 [details] [diff] [review]
bug-1003244.patch

let's wait for feedback before reviewing the code.
Attachment #8438745 - Flags: review?(glob)
Flags: needinfo?(konstantina)
It looks like you accidentally cleared the needinfo when the CC list changed? I still need to know the answers for the questions raised in comment #5 :-)
Flags: needinfo?(konstantina)
Hey Dylan,
fields correspending to Mozilla Space, Team, or Department Code need to be hardcoded as the csv example I sent you. The first e-mail column is also hardcoded while the second e-mail column is the bug's reporter e-mail.
As for the url you've sent me, unfortunately I don't have access.
Thanks for all the help
Flags: needinfo?(konstantina)
Alright, I think everything is set as it should be. I have fixed the group permissions on the bugzilla-dev site so you should be able to try the form now: https://bugzilla-dev.allizom.org/form:reps:swag

Hope it works as expected!
Flags: needinfo?(konstantina)
Hey Dyla,
thanks for this, one last thing, I've forgotten to mention that the Requester field is also hardcoded (sorry my mistake)
Everything else looks great :)
Flags: needinfo?(konstantina)
This is a cleaned up (hopefully de-nitted) patch with the Requester field hard-coded per above comment. I don't really see a need to push to dev but I'm open to the suggestion.
Attachment #8438745 - Attachment is obsolete: true
Attachment #8449155 - Flags: review?(glob)
Comment on attachment 8449155 [details] [diff] [review]
bug-1003244-final.patch

Review of attachment 8449155 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob nice

::: extensions/REMO/Extension.pm
@@ +280,5 @@
> +                  description => 'Remo Swag Request (CSV)',
> +                  filename    => 'remo-swag.csv',
> +                  ispatch     => 0,
> +                  isprivate   => 0,
> +                  mimetype    => 'text/csv' });

nit: drop }); down to the next line to match the prior attachment's formatting

@@ +298,1 @@
>              $bug->update($bug->creation_ts);

after this line add:
  delete $bug->{attachments};

this is required to make the attachments visible on the bug.
Attachment #8449155 - Flags: review?(glob) → review+
To gitolite3@git.mozilla.org:webtools/bmo/bugzilla.git
   e0d898d..3f631ad  master -> master

Leaving bug unresolved until this is pushed out.
(In reply to Dylan William Hardison [:dylan] from comment #14)
> Leaving bug unresolved until this is pushed out.

we resolve bugs as fixed when they are committed, not when they are deployed.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
this is now live.
thank you all for this!
Hi all, 

Since our department is change into Participation team, I'm reopening this bug to change the CSV file for the swag request. I'll upload the new CSV file here soon.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Rizki D Kelimutu [:kelimutu] from comment #18)
> Since our department is change into Participation team, I'm reopening this
> bug to change the CSV file for the swag request. I'll upload the new CSV
> file here soon.

please file a new bug with the required changes.

thanks.
Status: REOPENED → RESOLVED
Closed: 6 years ago3 years ago
Resolution: --- → FIXED
Here is the new CSV file. Basically, I'm just changing the Requester, Email, Team, and Department Code columns. Let me know if you need any other info. 

Thanks in advance
(In reply to Byron Jones ‹:glob› from comment #19)
> (In reply to Rizki D Kelimutu [:kelimutu] from comment #18)
> > Since our department is change into Participation team, I'm reopening this
> > bug to change the CSV file for the swag request. I'll upload the new CSV
> > file here soon.
> 
> please file a new bug with the required changes.
> 
> thanks.

Aaah. Ok.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Component: Extensions: REMO → Extensions
You need to log in before you can comment on or make changes to this bug.