1003253 - add better logging message to timeout failures

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Tomislav Jovanovic :zombie]

a timeout in a single test function can be due to more than different bug. especially true for intermittents!

see bug 1002826 for more details..

Comment 1

[Dave Townsend [:mossop]]

Can you describe what better logging you are looking for here?

Comment 2

[Ed Morley [:emorley]]

(In reply to Dave Townsend [:mossop] from comment #1)
> Can you describe what better logging you are looking for here?

The jetpack harness implementation of the idea in bug 1002826 comment 4 (that bug is more of a meta bug for all harnesses).

Comment 3

[Tomislav Jovanovic :zombie]

details are in bug 1002826 comment 4, but in short, add the last logged TEST-PASS (or TEST-START) line to the timeout message to distinguish between two different bug failures (like in bug 983277) that timeout at different points in the test.

Comment 4

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1649

i don't know if there is a good way to test this change (apart from manual testing of course).

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/c059763590dc5a7fb56ace36aecba0bd6f964f82
bug 1003253 - better logging after test timeout

https://github.com/mozilla/addon-sdk/commit/7432dcc7084fd88446a1934d88b8aeb3decdbee9
Merge pull request #1649 from zombie/1003253-timeout-after

bug 1003253 - better logging after test timeout, r=@Mossop

Comment 6

[Dave Townsend [:mossop]]

I reverted this for breaking the tree.

Comment 7

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1655

Comment 8

[Tomislav Jovanovic :zombie]

(In reply to Tomislav Jovanovic [:zombie] from comment #4)
> i don't know if there is a good way to test this change 

turns out we have tests for this, so i updated the ones that were failing..

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/3b7615cd131a79a53e06c27486051877a752abcb
bug 1003253 - better logging after test timeout, update test

https://github.com/mozilla/addon-sdk/commit/aa96259de889401927e6cad8902733c7ebdc699f
Merge pull request #1655 from zombie/1003253-timeout-after

bug 1003253 - better logging after test timeout, update test, r=@Mossop