1003304 - Return 'creator_detail' for /rest/bug/<bug_id>/attachment to avoid additional lookup for real_name

Status: NEW

(Bugzilla :: WebService, enhancement)

Description

[Ed Morley [:emorley]]

In bug 1003227 comment 3, I'm wanting to find out the email address and display name for attachments, so that qimportbz can fix up the hg patch header when the patch creator has forgotten to include the author info in the patch.

The attachment info endpoint (https://bugzilla.mozilla.org/rest/bug/1002780/attachment) only returns 'attacher' (the user_id email address), and not their real_name as well. 

I could make another call to /rest/user/<attacher_id> to find it out, but given that the main /rest/bug/<bug_id> endpoint returns real_name for a bunch of fields (eg under 'assigned_to_detail', 'cc_detail', 'creator_detail' and 'qa_contact_detail'), it seems we have a precedent for avoiding the additional lookup perhaps? I guess people can use include/exclude fields if they don't require it, to avoid additional joins in the DB query?

Comment 1

[Ed Morley [:emorley]]

Seems like if we were ok with adding this, we should move Bug::_user_to_hash() (added by bug 916254) to Util.pm or User.pm and use it for Bug.get as well as Attachment.get - yeah?

Comment 2

[David Lawrence [:dkl]]

We should do this as part of the upstream.

dkl

Comment 3

[:glob ✱]

(In reply to Ed Morley [:edmorley UTC+0] from comment #0)
> I guess people can use include/exclude fields if they don't require it, to avoid additional joins
> in the DB query?

now that bug 540818 has landed, that's exactly what we should do :)

Comment 4

[Simon Green]

Attachment: bug1003304-v1.patch

Comment 5

[Gervase Markham [:gerv]]

Comment on attachment 8798793 [details] [diff] [review]
bug1003304-v1.patch

I'm sorry, but I will be unable to do this review. My apologies :-(

Gerv

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 8798793 [details] [diff] [review]
bug1003304-v1.patch

Review of attachment 8798793 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good code-wise. Assume you have tested it with latest master. r=dkl

Comment 7

[Ed Morley [:emorley]]

This bug has an r+'d patch - could someone land it?

Comment 8

[Priscilla Howard]

Attachment: habralosi19889627.txt

Thanks from biotavelri1970.

Comment 9

[David Lawrence [:dkl]]

The content of attachment 9381636 [details] has been deleted for the following reason:

Spam