1003380 - Calling createPattern with a broken image must throw an invalidstate error

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Comment 1

[Rik Cabanier]

See: 
 http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-createpattern
and
  http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas_CR/#dom-context-2d-createpattern

Chrome also has this behavior.

Comment 2

[Rik Cabanier]

Attachment: implementation + test cases for createPattern with a broken image

Comment 3

[Rik Cabanier]

Comment on attachment 8414710 [details] [diff] [review]
implementation + test cases for createPattern with a broken image

Try build: https://tbpl.mozilla.org/?tree=Try&rev=4f089261fb35

Comment 5

[Rik Cabanier]

Attachment: implementation + test cases for createPattern with a broken image

Comment 6

[Rik Cabanier]

try build: https://tbpl.mozilla.org/?tree=Try&rev=3a41a76e3e2b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c2f46733945

With the bug number in the commit message fixed ;)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

This was failing frequently (but not always) on Android. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/34887cdb5616

https://tbpl.mozilla.org/php/getParsedLog.php?id=38816070&tree=Mozilla-Inbound

Comment 9

[Rik Cabanier]

Attachment: implementation + test cases for createPattern with a broken image

Removed flaky test from test_canvas.html
Broken state should be tested after document load which is done by the smaller test.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e72eab5fab7

With the bug number in the commit message fixed again.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Still failing frequently on Android. Please confirm on Try that this test passes reliably before requesting checkin a third time. If you need help learning how to retrigger jobs on TBPL, feel free to ping in IRC. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ac19d49bfba

https://tbpl.mozilla.org/php/getParsedLog.php?id=38890633&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=38890519&tree=Mozilla-Inbound

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5e72eab5fab7

Comment 13

[Rik Cabanier]

Attachment: implementation + test cases for createPattern with a broken image

Try run:  https://tbpl.mozilla.org/?tree=Try&rev=153fcd334f5d
I did a push but was unable to add additional tests because I didn't have permission to do so.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Rik, could you propose a wording for the release notes? thanks

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd8c63e9eb92

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd8c63e9eb92

Comment 17

[Rik Cabanier]

(In reply to Sylvestre Ledru [:sylvestre] from comment #14)
> Rik, could you propose a wording for the release notes? thanks

I'm unsure if this is important enough for the release notes :-)
Basically, createPattern ignored broken images before and drew with transparent black. After this change, an invalid state error is thrown.

Comment 18

[Sylvestre Ledru [:Sylvestre]]

(In reply to Rik Cabanier from comment #17)
> I'm unsure if this is important enough for the release notes :-)
I agree with you. So, not adding it to the release notes. 
By the way, no sentences in the release notes ;)