Closed
Bug 1003380
Opened 10 years ago
Closed 10 years ago
Calling createPattern with a broken image must throw an invalidstate error
Categories
(Core :: Graphics: Canvas2D, defect)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: cabanier, Assigned: cabanier)
Details
(Keywords: relnote)
Attachments
(1 file, 3 obsolete files)
No description provided.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → cabanier
Assignee | ||
Comment 1•10 years ago
|
||
See: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-context-2d-createpattern and http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas_CR/#dom-context-2d-createpattern Chrome also has this behavior.
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8414710 [details] [diff] [review] implementation + test cases for createPattern with a broken image Try build: https://tbpl.mozilla.org/?tree=Try&rev=4f089261fb35
Attachment #8414710 -
Flags: review?(bas)
Assignee | ||
Updated•10 years ago
|
Attachment #8414710 -
Flags: review?(bas)
Updated•10 years ago
|
Attachment #8414710 -
Flags: review+
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8414710 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
try build: https://tbpl.mozilla.org/?tree=Try&rev=3a41a76e3e2b
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c2f46733945 With the bug number in the commit message fixed ;)
Keywords: checkin-needed
Comment 8•10 years ago
|
||
This was failing frequently (but not always) on Android. Backed out. https://hg.mozilla.org/integration/mozilla-inbound/rev/34887cdb5616 https://tbpl.mozilla.org/php/getParsedLog.php?id=38816070&tree=Mozilla-Inbound
Assignee | ||
Comment 9•10 years ago
|
||
Removed flaky test from test_canvas.html Broken state should be tested after document load which is done by the smaller test.
Attachment #8415070 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e72eab5fab7 With the bug number in the commit message fixed again.
Flags: in-testsuite+
Keywords: checkin-needed
Comment 11•10 years ago
|
||
Still failing frequently on Android. Please confirm on Try that this test passes reliably before requesting checkin a third time. If you need help learning how to retrigger jobs on TBPL, feel free to ping in IRC. Backed out. https://hg.mozilla.org/integration/mozilla-inbound/rev/0ac19d49bfba https://tbpl.mozilla.org/php/getParsedLog.php?id=38890633&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=38890519&tree=Mozilla-Inbound
https://hg.mozilla.org/mozilla-central/rev/5e72eab5fab7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Assignee | ||
Comment 13•10 years ago
|
||
Try run: https://tbpl.mozilla.org/?tree=Try&rev=153fcd334f5d I did a push but was unable to add additional tests because I didn't have permission to do so.
Attachment #8415464 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla32 → ---
Assignee | ||
Updated•10 years ago
|
Comment 14•10 years ago
|
||
Rik, could you propose a wording for the release notes? thanks
Flags: needinfo?(cabanier)
Comment 15•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd8c63e9eb92
Keywords: checkin-needed
Comment 16•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bd8c63e9eb92
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Assignee | ||
Comment 17•10 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #14) > Rik, could you propose a wording for the release notes? thanks I'm unsure if this is important enough for the release notes :-) Basically, createPattern ignored broken images before and drew with transparent black. After this change, an invalid state error is thrown.
Flags: needinfo?(cabanier)
Comment 18•10 years ago
|
||
(In reply to Rik Cabanier from comment #17) > I'm unsure if this is important enough for the release notes :-) I agree with you. So, not adding it to the release notes. By the way, no sentences in the release notes ;)
You need to log in
before you can comment on or make changes to this bug.
Description
•