Closed Bug 1003380 Opened 10 years ago Closed 10 years ago

Calling createPattern with a broken image must throw an invalidstate error

Categories

(Core :: Graphics: Canvas2D, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32
Tracking Status
relnote-firefox --- -
relnote-b2g --- -

People

(Reporter: cabanier, Assigned: cabanier)

Details

(Keywords: relnote)

Attachments

(1 file, 3 obsolete files)

      No description provided.
Assignee: nobody → cabanier
Comment on attachment 8414710 [details] [diff] [review]
implementation + test cases for createPattern with a broken image

Try build: https://tbpl.mozilla.org/?tree=Try&rev=4f089261fb35
Attachment #8414710 - Flags: review?(bas)
Attachment #8414710 - Flags: review?(bas)
Attachment #8414710 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c2f46733945

With the bug number in the commit message fixed ;)
Keywords: checkin-needed
Removed flaky test from test_canvas.html
Broken state should be tested after document load which is done by the smaller test.
Attachment #8415070 - Attachment is obsolete: true
Keywords: checkin-needed
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e72eab5fab7

With the bug number in the commit message fixed again.
Flags: in-testsuite+
Keywords: checkin-needed
Still failing frequently on Android. Please confirm on Try that this test passes reliably before requesting checkin a third time. If you need help learning how to retrigger jobs on TBPL, feel free to ping in IRC. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ac19d49bfba

https://tbpl.mozilla.org/php/getParsedLog.php?id=38890633&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=38890519&tree=Mozilla-Inbound
https://hg.mozilla.org/mozilla-central/rev/5e72eab5fab7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Try run:  https://tbpl.mozilla.org/?tree=Try&rev=153fcd334f5d
I did a push but was unable to add additional tests because I didn't have permission to do so.
Attachment #8415464 - Attachment is obsolete: true
Keywords: checkin-needed
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla32 → ---
relnote-firefox: --- → ?
relnote-b2g: --- → ?
Keywords: relnote
Rik, could you propose a wording for the release notes? thanks
Flags: needinfo?(cabanier)
https://hg.mozilla.org/mozilla-central/rev/bd8c63e9eb92
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
(In reply to Sylvestre Ledru [:sylvestre] from comment #14)
> Rik, could you propose a wording for the release notes? thanks

I'm unsure if this is important enough for the release notes :-)
Basically, createPattern ignored broken images before and drew with transparent black. After this change, an invalid state error is thrown.
Flags: needinfo?(cabanier)
(In reply to Rik Cabanier from comment #17)
> I'm unsure if this is important enough for the release notes :-)
I agree with you. So, not adding it to the release notes. 
By the way, no sentences in the release notes ;)
You need to log in before you can comment on or make changes to this bug.