1003654 - [e10s] "FindBar Tweak" addon does not work

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Install "FindBar Tweak" addon: https://addons.mozilla.org/en-US/firefox/addon/findbar-tweak/
2. Restart Firefox in e10s mode and watch the console.

RESULT:

System JS : ERROR resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///Users/cpeterson/Library/Application%20Support/Firefox/Profiles/ex2170bl.Test/extensions/[e-mail]!/bootstrap.js -> resource://findbartweak/modules/utils/moduleAid.jsm -> resource://findbartweak/modules/utils/browserMediator.jsm:32 - TypeError: aBrowser.contentDocument is null

System JS : ERROR resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///Users/cpeterson/Library/Application%20Support/Firefox/Profiles/ex2170bl.Test/extensions/[e-mail]!/bootstrap.js -> resource://findbartweak/modules/utils/moduleAid.jsm -> resource://findbartweak/modules/utils/browserMediator.jsm:32 - TypeError: aBrowser.contentDocument is null

System JS : ERROR resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///Users/cpeterson/Library/Application%20Support/Firefox/Profiles/ex2170bl.Test/extensions/[e-mail]!/bootstrap.js -> resource://findbartweak/modules/utils/moduleAid.jsm -> resource://findbartweak/modules/utils/browserMediator.jsm:32 - TypeError: aBrowser.contentDocument is null

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "[JavaScript Error: "gBrowser.tabContainer.childNodes[i].linkedBrowser.contentDocument is null" {file: "resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///Users/cpeterson/Library/Application%20Support/Firefox/Profiles/ex2170bl.Test/extensions/[e-mail]!/bootstrap.js -> resource://findbartweak/modules/utils/moduleAid.jsm -> resource://findbartweak/modules/highlights.jsm" line: 307}]'[JavaScript Error: "gBrowser.tabContainer.childNodes[i].linkedBrowser.contentDocument is null" {file: "resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///Users/cpeterson/Library/Application%20Support/Firefox/Profiles/ex2170bl.Test/extensions/[e-mail]!/bootstrap.js -> resource://findbartweak/modules/utils/moduleAid.jsm -> resource://findbartweak/modules/highlights.jsm" line: 307}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************

System JS : ERROR resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///Users/cpeterson/Library/Application%20Support/Firefox/Profiles/ex2170bl.Test/extensions/[e-mail]!/bootstrap.js -> resource://findbartweak/modules/utils/moduleAid.jsm -> resource://findbartweak/modules/highlights.jsm:103 - TypeError: contentDocument is null

Comment 1

[Luís Miguel [:quicksaver] (not reading bugmail)]

(I'm the developer of FBT) I haven't made it compatible with e10s yet, still working on it, it won't be easy (or soon) as it touches web content directly in multiple places, so it requires almost a complete rewrite of pretty much everything, and will depend on others like bug 942707 and bug 1004515 for full compatibility.

I'm ok with leaving this bug open to track any other issues with FBT and e10s when I do release a compatible version though, but I'll leave that decision up to the e10s ruling deities. :)

Also, renamed summary because that error is just one of many, it's only one of the few that shows because it's the one that fires first and stops most of the rest of the execution, preventing many others from even triggering.

Comment 2

[Chris Peterson [:cpeterson]]

Thanks, Luís! We can leave this bug open to track any other FBT issues. That's a good idea.

If you have any questions about e10s and using content scripts to touch web content, just drop by the #e10s IRC channel on irc.mozilla.org. :)

Comment 3

[Luís Miguel [:quicksaver] (not reading bugmail)]

Just uploaded beta version 2b2 (in the Development Channel section at https://addons.mozilla.org/firefox/addon/findbar-tweak/) which should be completely compatible with e10s.

I'll close this bug once I release the final version; it might still take a little while longer, as there's a bunch of new features I want to add before that, plus I'm sure that after such a big rewrite ( 13,713 additions and 10,094 deletions since the previous beta, wow!) there are still bugs laying around that need fixing.

Comment 4

[Jerod Lycett]

This appears to be working in e10s in Aurora. Should be closed.

Comment 5

[Luís Miguel [:quicksaver] (not reading bugmail)]

Only the latest version 2 is e10s compatible. It's already in the queue to be reviewed, I'll close the bug when that version is approved.

Comment 6

[Jerod Lycett]

(In reply to Luís Miguel [:Quicksaver] from comment #5)
> Only the latest version 2 is e10s compatible. It's already in the queue to
> be reviewed, I'll close the bug when that version is approved.

I just tested the latest reviewed version from AMO with it. Version 1.4.18.1-signed if you want to leave the bug open feel free, but it does appear to be fixed somehow.

Comment 7

[Luís Miguel [:quicksaver] (not reading bugmail)]

It's possible some of the latest compatibility shims make the add-on usable up to a point, but trust me it's far from completely working in there, and the parts that may work are definitely performing sub-par because of that. ;)

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

The updated version has been approved.