Closed Bug 1003657 Opened 11 years ago Closed 11 years ago

[Bluedroid] The memory of ReplyRunnable for DefaultAdapterPathRequest wouldn't be released and becomes a leak.

Tracking

(blocking-b2g:1.4+, firefox30 wontfix, firefox31 wontfix, firefox32 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

Status:

RESOLVED FIXED

Milestone:

2.0 S1 (9may)

Project Flags:

blocking-b2g

1.4+

Tracking Flags:

Tracking

Status

firefox30

---

wontfix

firefox31

---

wontfix

firefox32

---

fixed

b2g-v1.4

---

fixed

b2g-v2.0

---

fixed

People

(Reporter: jaliu, Assigned: jaliu)

References

Details

(Whiteboard: [p=1],)

Attachments

(2 files, 1 obsolete file)

Don't keep reference in GetDefaultAdapterPathInternal to avoid memory leak. (v0) 11 years ago Jamin Liu [:jaliu][:Jamin] 1.47 KB, patch	echou : review+ shawnjohnjr : feedback+	Details \| Diff \| Splinter Review
(final) Don't keep reference in GetDefaultAdapterPathInternal to avoid memory leak. (v0) r=echou, f=shuang 11 years ago Jamin Liu [:jaliu][:Jamin] 1.27 KB, patch		Details \| Diff \| Splinter Review
(for 1.4) Don't keep reference in GetDefaultAdapterPathInternal to avoid memory leak. (v0) r=echou, f=shuang 11 years ago Jamin Liu [:jaliu][:Jamin] 1.31 KB, patch		Details \| Diff \| Splinter Review

Jamin Liu [:jaliu][:Jamin]

Assignee

Description

•

11 years ago

The memory of BluetoothRequestParent::ReplyRunnable for DefaultAdapterPathRequest wouldn't be released and becomes a leak. Please refer to ipc/BluetoothParent.cpp STR: 1. Enable BT 2. Disable BT 3. Kill setting app 4. Check the log in destructor of BluetoothRequestParent::ReplyRunnable

Jamin Liu [:jaliu][:Jamin]

Assignee

Updated

•

11 years ago

Assignee: nobody → jaliu

Jamin Liu [:jaliu][:Jamin]

Assignee

Updated

•

11 years ago

Summary: The memory of ReplyRunnable for DefaultAdapterPathRequest wouldn't be released and becomes a leak. → [Bluedroid] The memory of ReplyRunnable for DefaultAdapterPathRequest wouldn't be released and becomes a leak.

Jamin Liu [:jaliu][:Jamin]

Assignee

Comment 1

•

11 years ago

Attached patch Don't keep reference in GetDefaultAdapterPathInternal to avoid memory leak. (v0) (obsolete) — Details — Splinter Review

Jamin Liu [:jaliu][:Jamin]

Assignee

Updated

•

11 years ago

Status: NEW → ASSIGNED

Jamin Liu [:jaliu][:Jamin]

Assignee

Updated

•

11 years ago

Attachment #8415017 - Flags: review?(echou)

Attachment #8415017 - Flags: feedback?(shuang)

Jamin Liu [:jaliu][:Jamin]

Assignee

Updated

•

11 years ago

Updated

•

11 years ago

Attachment #8415017 - Flags: review?(echou) → review+

Michael Vines [:m1] [:evilmachines]

Updated

•

11 years ago

Blocks: 997962

Michael Vines [:m1] [:evilmachines]

Updated

•

11 years ago

blocking-b2g: --- → 1.4?

Preeti Raghunath(:Preeti)

Comment 2

•

11 years ago

1.4+ for BT issues

blocking-b2g: 1.4? → 1.4+

Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)

Updated

•

11 years ago

Attachment #8415017 - Flags: feedback?(shuang) → feedback+

Jamin Liu [:jaliu][:Jamin]

Assignee

Updated

•

11 years ago

Whiteboard: [p=1]

Jamin Liu [:jaliu][:Jamin]

Assignee

Updated

•

11 years ago

Whiteboard: [p=1] → [p=1], [ETA:5/7]

Jamin Liu [:jaliu][:Jamin]

Assignee

Comment 3

•

11 years ago

Attached patch (final) Don't keep reference in GetDefaultAdapterPathInternal to avoid memory leak. (v0) r=echou, f=shuang — Details — Splinter Review

Attachment #8415017 - Attachment is obsolete: true

Jamin Liu [:jaliu][:Jamin]

Assignee

Updated

•

11 years ago

Keywords: checkin-needed

Eric Chou [:ericchou] [:echou]

Comment 4

•

11 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/62f0d6603ca8

Keywords: checkin-needed

Jamin Liu [:jaliu][:Jamin]

Assignee

Comment 5

•

11 years ago

Attached patch (for 1.4) Don't keep reference in GetDefaultAdapterPathInternal to avoid memory leak. (v0) r=echou, f=shuang — Details — Splinter Review

Attachment #8417784 - Attachment is obsolete: true

Jamin Liu [:jaliu][:Jamin]

Assignee

Updated

•

11 years ago

Attachment #8417784 - Attachment is obsolete: false

Carsten Book [:Tomcat]

Comment 6

•

11 years ago

https://hg.mozilla.org/mozilla-central/rev/62f0d6603ca8

Status: ASSIGNED → RESOLVED

Closed: 11 years ago

Resolution: --- → FIXED

Ryan VanderMeulen [:RyanVM]

Comment 7

•

11 years ago

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/2389aff15c81

status-b2g-v1.4: --- → fixed

status-b2g-v2.0: --- → fixed

status-firefox30: --- → wontfix

status-firefox31: --- → wontfix

status-firefox32: --- → fixed

Whiteboard: [p=1], [ETA:5/7] → [p=1],

Target Milestone: --- → 2.0 S1 (9may)

You need to log in before you can comment on or make changes to this bug.