Closed
Bug 1003702
Opened 10 years ago
Closed 10 years ago
Suppress clang warnings in third-party code: ICU
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
7.22 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Suppress the following (63!) clang warnings in third-party ICU code. I wasn't sure if I should request review from glandium, Waldo, or smontagu for this patch to the intl/icu makefiles. intl/icu/source/common/putil.cpp:167:19 [-Wunused-const-variable] unused variable 'copyright' intl/icu/source/common/ucnv.c:303:43 [-Wsign-compare] comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'int' intl/icu/source/common/ucnv.c:393:49 [-Wsign-compare] comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'int' intl/icu/source/common/udataswp.c:252:29 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/udataswp.c:372:29 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/udataswp.c:380:29 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/uhash.c:217:44 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/uhash.c:401:29 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/uhash.c:554:13 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/ulist.c:132:24 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/uloc_tag.c:638:16 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/uloc_tag.c:700:19 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/uloc_tag.c:778:16 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/uloc_tag.c:797:17 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/uloc_tag.c:896:16 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/uloc_tag.c:1181:66 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/unorm_it.c:560:38 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/ures_cnv.c:44:18 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/ures_cnv.c:62:22 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/uresdata.c:1075:26 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/common/utrace.c:147:16 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/i18n/decNumber.c:218:20 [-Wunused-const-variable] unused variable 'DECSTICKYTAB' intl/icu/source/i18n/decNumber.c:5006:21 [-Wsign-compare] comparison of integers of different signs: 'int32_t' (aka 'int') and 'unsigned long' intl/icu/source/i18n/digitlst.cpp:61:22 [-Wunused-const-variable] unused variable 'DIGIT_HAVE_NONE' intl/icu/source/i18n/digitlst.cpp:62:22 [-Wunused-const-variable] unused variable 'DIGIT_HAVE_DOUBLE' intl/icu/source/i18n/digitlst.cpp:63:22 [-Wunused-const-variable] unused variable 'DIGIT_HAVE_INT64' intl/icu/source/i18n/locdspnm.cpp:495:66 [-Wunused-parameter] unused parameter 'usage' intl/icu/source/i18n/plurrule.cpp:52:20 [-Wunused-const-variable] unused variable 'PK_VAR_J' intl/icu/source/i18n/smpdtfmt.cpp:1194:45 [-Wunused-parameter] unused parameter 'capitalizationContext' intl/icu/source/i18n/smpdtfmt.cpp:1195:37 [-Wunused-parameter] unused parameter 'fieldNum' intl/icu/source/i18n/ucln_in.c:26:19 [-Wunused-const-variable] unused variable 'copyright' intl/icu/source/i18n/uspoof_build.cpp:48:35 [-Wunused-parameter] unused parameter 'confusables' intl/icu/source/i18n/uspoof_build.cpp:48:57 [-Wunused-parameter] unused parameter 'confusablesLen' intl/icu/source/i18n/uspoof_build.cpp:49:35 [-Wunused-parameter] unused parameter 'confusablesWholeScript' intl/icu/source/i18n/uspoof_build.cpp:49:67 [-Wunused-parameter] unused parameter 'confusablesWholeScriptLen' intl/icu/source/i18n/uspoof_build.cpp:50:32 [-Wunused-parameter] unused parameter 'errorType' intl/icu/source/i18n/uspoof_build.cpp:50:56 [-Wunused-parameter] unused parameter 'pe' intl/icu/source/tools/gencfu/gencfu.cpp:302:21 [-Wunused-function] unused function 'readFile' intl/icu/source/tools/gendict/gendict.cpp:253:14 [-Wunused-function] unused function 'readLine' intl/icu/source/tools/gendict/gendict.cpp:293:11 [-Wunused-variable] unused variable 'verbose' intl/icu/source/tools/gendict/gendict.cpp:300:17 [-Wunused-variable] unused variable 'wordFileName' intl/icu/source/tools/genrb/read.c:165:23 [-Wsign-compare] comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' intl/icu/source/tools/genrb/read.c:182:27 [-Wsign-compare] comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' intl/icu/source/tools/genrb/read.c:243:23 [-Wsign-compare] comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' intl/icu/source/tools/genrb/read.c:262:23 [-Wsign-compare] comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' intl/icu/source/tools/genrb/read.c:288:27 [-Wsign-compare] comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' intl/icu/source/tools/genrb/read.c:332:15 [-Wsign-compare] comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' intl/icu/source/tools/genrb/read.c:347:15 [-Wsign-compare] comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' intl/icu/source/tools/genrb/read.c:391:33 [-Wsign-compare] comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' intl/icu/source/tools/genrb/read.c:425:16 [-Wsign-compare] comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' intl/icu/source/tools/genrb/read.c:427:11 [-Wsign-compare] comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' intl/icu/source/tools/genrb/wrtxml.cpp:387:1 [-Wunused-function] unused function 'print' intl/icu/source/tools/genrb/wrtxml.cpp:412:35 [-Wunused-parameter] unused parameter 'src' intl/icu/source/tools/genrb/wrtxml.cpp:412:52 [-Wunused-parameter] unused parameter 'status' intl/icu/source/tools/genrb/wrtxml.cpp:462:13 [-Wunused-function] unused function 'printAttribute' intl/icu/source/tools/genrb/wrtxml.cpp:472:31 [-Wunused-parameter] unused parameter 'src' intl/icu/source/tools/genrb/wrtxml.cpp:472:48 [-Wunused-parameter] unused parameter 'resName' intl/icu/source/tools/genrb/wrtxml.cpp:472:63 [-Wunused-parameter] unused parameter 'printTranslate' intl/icu/source/tools/genrb/wrtxml.cpp:472:91 [-Wunused-parameter] unused parameter 'status' intl/icu/source/tools/pkgdata/pkgtypes.c:226:24 [-Wsign-compare] comparison of integers of different signs: 'long' and 'unsigned long' intl/icu/source/tools/toolutil/flagparser.c:62:37 [-Wsign-compare] comparison of integers of different signs: 'unsigned long' and 'int' intl/icu/source/tools/toolutil/ucbuf.c:419:11 [-Wsign-compare] comparison of integers of different signs: 'UChar32' (aka 'int') and 'unsigned int' intl/icu/source/tools/toolutil/unewdata.c:77:16 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long'
Attachment #8415038 -
Flags: review?(mh+mozilla)
Comment 1•10 years ago
|
||
Comment on attachment 8415038 [details] [diff] [review] suppress-icu-warnings.patch Review of attachment 8415038 [details] [diff] [review]: ----------------------------------------------------------------- Please upstream, too.
Attachment #8415038 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d26d6aab28da
Comment 3•10 years ago
|
||
Backed out out for breaking the world https://hg.mozilla.org/integration/mozilla-inbound/rev/e6dd7032e3da https://tbpl.mozilla.org/php/getParsedLog.php?id=38858800&tree=Mozilla-Inbound&full=1
Assignee | ||
Comment 4•10 years ago
|
||
Sorry! I think this change might require a clobber. I am testing a clobber on try now.
Assignee | ||
Comment 5•10 years ago
|
||
As requested by review comment 1, I reported these warnings to ICU upstream: http://bugs.icu-project.org/trac/ticket/10861
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/57ed333a91f1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Assignee | ||
Comment 7•10 years ago
|
||
Relanded ICU changes with clobber: https://hg.mozilla.org/integration/mozilla-inbound/rev/2df94d46bc5a
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2df94d46bc5a
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 9•10 years ago
|
||
(In reply to Chris Peterson (:cpeterson) from comment #4) > Sorry! I think this change might require a clobber. I am testing a clobber > on try now. Note that try always clobbers.
You need to log in
before you can comment on or make changes to this bug.
Description
•