1003725 - [FTU-separation] Move import.html and related resources to shared/pages/import

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

We need to move the entire import.html and related resources to shared/pages

Comment 1

[Jose Manuel Cantera]

Attachment: 18750.html

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8415069 [details]
18750.html

Thanks!

Please be sure travis is green before merging.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

No new tests, since we are just moving code and modifying the current tests to make it work.

Comment 5

[Jose Manuel Cantera]

Comment on attachment 8415069 [details]
18750.html

FCampo is on PTO

Comment 6

[Jose Manuel Cantera]

https://github.com/jmcanterafonseca/gaia/commit/ffb1753bd2e3774e001fee943d553a5f58b01eb7

Comment 7

[Julien Wajsberg [:julienw]]

(In reply to Francisco Jordano [:arcturus] (on PTO till 19th May) from comment #3)
> 
> Please be sure travis is green before merging.

Seems it was not green before merging: https://travis-ci.org/mozilla-b2g/gaia/builds/24440922

I backed out for several travis failures.

master: 980c23ac9b349aef2fec662dfb35c4f22411f141

Also, since you changed a system build file, you need to ask a review from either ochameau or yurenju. You can't just change this without asking anyone.

Thanks

Comment 8

[Ryan VanderMeulen [:RyanVM]]

This broke TBPL pretty badly too. Thanks for reverting.

Comment 9

[Jose Manuel Cantera]

relanded:

https://github.com/mozilla-b2g/gaia/commit/fa23dbd9a79cbb9b39008bdc9a312cc49f74eeaa