1003787 - [Contacts] Different texts to delete contacts: "Delete X contact?.." in title and text "Remove" in button.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Loli (:lolimartinezcr)]

Tested
1.5
Hamachi
Gecko: 13b2542
Gaia: 08ea844

Reproducible: 100%

Pre-requisites: Contacts created.
STRs:
1) Tap contacts aplication.
2) Tap settings.
3) Tap "Delete contacts" button.
4) Tap "Select all" button.
5) Tap "Delete" button

Actual result:
Screen : "Delete x contacts? this cannot be undone." and "Cancel" and "Remove" button.
Two differents texts in title and in button: "Delete" and "Remove"

Expected result:
Screen: "Delete x contacts? this cannot be undone." and "Cancel" and "Delete" button.
Same texts in title and in button: "Delete".

Comment 1

[Maria Angeles Oteo (:oteo)]

The same error appears when you delete a contact from contact detail screen

Actual result:
Screen : "Delete contact?"  and "Cancel" and "Remove" button.
Two differents strings in title and in button: "Delete" and "Remove"

Expected result:
Screen: "Delete contact?" and "Cancel" and "Delete" button.
Same string in title and in button: "Delete".

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Delete contact.png

Just to confirm if it is correct

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: multiple delete.png

Just to confirm if it is correct too

Comment 5

[Maria Angeles Oteo (:oteo)]

It's perfect Cristian, according to Vicky's proposal to fix some inconsistencies when "Multiple Contact Delete" feature was landed https://bug991141.bugzilla.mozilla.org/attachment.cgi?id=8400729 (screen 2)

Comment 6

[Jose Manuel Cantera]

Comment on attachment 8416372 [details]
Patch v1

thanks for fixing it.

Comment 7

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/e8a08a3f7a608993f0b302371e016e73faceea70

Comment 8

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.0
Gecko:b2cdbab
Gaia:7c55cc2