1003897 - Character Encoding selection broken in Fennec 29

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

https://support.mozilla.org/en-US/questions/997382

Character Encoding selection via menu is broken in Firefox 29. Confirmed.

Tested this on trunk (32) → (30) and it works. Can we figure out what fixed this? 

We should release note.

Comment 1

[Aaron Train [:aaronmt]]

This is the error on Firefox 29

E/GeckoBrowserApp(10094): error parsing json
E/GeckoBrowserApp(10094): org.json.JSONException: No value for code
E/GeckoBrowserApp(10094): 	at org.json.JSONObject.get(JSONObject.java:355)
E/GeckoBrowserApp(10094): 	at org.json.JSONObject.getString(JSONObject.java:515)
E/GeckoBrowserApp(10094): 	at org.mozilla.gecko.BrowserApp$24.onClick(BrowserApp.java:1147)
E/GeckoBrowserApp(10094): 	at com.android.internal.app.AlertController$AlertParams$3.onItemClick(AlertController.java:941)
E/GeckoBrowserApp(10094): 	at android.widget.AdapterView.performItemClick(AdapterView.java:299)
E/GeckoBrowserApp(10094): 	at android.widget.AbsListView.performItemClick(AbsListView.java:1113)
E/GeckoBrowserApp(10094): 	at android.widget.AbsListView$PerformClick.run(AbsListView.java:2904)
E/GeckoBrowserApp(10094): 	at android.widget.AbsListView$3.run(AbsListView.java:3638)
E/GeckoBrowserApp(10094): 	at android.os.Handler.handleCallback(Handler.java:733)
E/GeckoBrowserApp(10094): 	at android.os.Handler.dispatchMessage(Handler.java:95)
E/GeckoBrowserApp(10094): 	at android.os.Looper.loop(Looper.java:136)
E/GeckoBrowserApp(10094): 	at android.app.ActivityThread.main(ActivityThread.java:5017)
E/GeckoBrowserApp(10094): 	at java.lang.reflect.Method.invokeNative(Native Method)
E/GeckoBrowserApp(10094): 	at java.lang.reflect.Method.invoke(Method.java:515)
E/GeckoBrowserApp(10094): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
E/GeckoBrowserApp(10094): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
E/GeckoBrowserApp(10094): 	at dalvik.system.NativeStart.main(Native Method)

Comment 2

[:Margaret Leibovic]

Bug 943262 changed the character encoding menu, but it was uplifted to 29. Perhaps there is some difference in the toolkit code that is causing the patch to not work on 29, but somehow work on 32/31/30.

Comment 3

[:Margaret Leibovic]

I can make a local release build to investigate.

Comment 4

[:Margaret Leibovic]

Yup, this looks like it's caused by the fact that bug 956657 isn't in Fx29.

I think the easiest solution would be to just back bug 943262 out of release if we want this for a point release.

Comment 5

[:Margaret Leibovic]

I just made a build with this changeset backed out:
https://hg.mozilla.org/releases/mozilla-beta/rev/b84e23f32f81

And I can confirm that fixes the problem by restoring the old character encoding menu.

Comment 6

[Henri Sivonen (:hsivonen)]

Changing Firefox to Fennec in summary so that people who don't look at the component realize that this doesn't affect desktop.

Comment 7

[Henri Sivonen (:hsivonen)]

Usage across locales (selection made from menu at least once in the session vs. selection not made from the menu at all in the session) in Fennec 28:
http://telemetry.mozilla.org/#release/28/CHARSET_OVERRIDE_USED/saved_session/Fennec

Usage data by locale for Firefox 26 and Fennec 26 (scroll down):
https://bug965707.bugzilla.mozilla.org/attachment.cgi?id=8381394

The rows that are gray are for locales that have so few total sessions
that only a few uses of the menu sway the percentages in a big way.
Please pay no attention to the gray rows. 26 had inappropriate fallback
values for Traditional Chinese,Thai, Czech and Arabic (among others), so
one should expect the usage rate in the Traditional Chinese,Thai, Czech
and Arabic locales to have gone down in Firefox 28 where the fallback
values were fixed. Therefore, please don't put too much weight on the
zh-TW, th, cs and ar rows for the purpose of making decisions about
Fennec 29. Also, the "Times used" column is slightly mis-labeled. It
means the number of sessions were the menu was used at least once. Since
en-US is the catch-all locale, it doesn't truly represent the American
user experience.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

reported in the release notes:
http://www.mozilla.org/en-US/mobile/29.0/releasenotes/

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Bug 943262 backed out from mozilla-release.

https://hg.mozilla.org/releases/mozilla-release/rev/6b14de55b252

Comment 10

[Catalin Suciu [:csuciu]]

This issue is verified as fixed on Firefox for Android 29.0.1

Comment 11

[Cristina Madaras, QA [:CristinaM]]

Test cases added in Moztrap:
https://moztrap.mozilla.org/manage/case/14082/ - Character encoding selection