Closed
Bug 1003918
Opened 10 years ago
Closed 10 years ago
Rename ionTop to jitTop
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(1 file)
41.49 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
This week's cleanup patch. There were more uses of ionTop than I expected. This patch also moves ionReturnOverride_ from JSRuntime to JitRuntime.
Attachment #8415372 -
Flags: review?(shu)
Comment 1•10 years ago
|
||
Comment on attachment 8415372 [details] [diff] [review] Patch Review of attachment 8415372 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me! ::: js/src/jit/JitCompartment.h @@ +356,5 @@ > return forkJoinGetSliceStub_; > } > + > + bool hasIonReturnOverride() const { > + return !ionReturnOverride_.isMagic(); Just wondering: can we tighten this to !isMagic(JS_ARG_POSION), or are other magic values supported as return values? ::: js/src/jit/x64/MacroAssembler-x64.h @@ +1300,5 @@ > orq(Imm32(type), frameSizeReg); > } > > // Save an exit frame (which must be aligned to the stack pointer) to > + // ThreadData::jitTop of the main thread. Nit: preexisting; ThreadData -> PerThreadData ::: js/src/jit/x86/MacroAssembler-x86.h @@ +1097,5 @@ > orl(Imm32(type), frameSizeReg); > } > > // Save an exit frame (which must be aligned to the stack pointer) to > + // ThreadData::jitTop of the main thread. Ditto.
Attachment #8415372 -
Flags: review?(shu) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa468cb36e5e (In reply to Shu-yu Guo [:shu] from comment #1) > Just wondering: can we tighten this to !isMagic(JS_ARG_POSION), or are other > magic values supported as return values? Good idea, done. We shouldn't see other magic values there AFAIK.
Assignee | ||
Comment 3•10 years ago
|
||
Followup to unbreak non-unified builds: https://hg.mozilla.org/integration/mozilla-inbound/rev/7210c4f043a5
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fa468cb36e5e https://hg.mozilla.org/mozilla-central/rev/7210c4f043a5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•