1003945 - Changing preprocessor defines doesn't re-preprocess preprocessed WebIDL files (Clobber needed after landing bug 852935)

Status: REOPENED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

bug 852935 enabled the Gamepad API on Android. It included a change to configure.in that would cause MOZ_GAMEPAD to be set when building for Android. This patch was green on try, but when pushed to inbound it resulted in Mochitest failures trying to run the Gamepad Mochitests:
https://tbpl.mozilla.org/php/getParsedLog.php?id=38814198&tree=Mozilla-Inbound

Note:
http://hg.mozilla.org/mozilla-central/annotate/b1d730203bb6/dom/webidl/moz.build#l503

Comment 1

[(not currently active) Ted Mielczarek]

The build log shows configure running:
https://tbpl.mozilla.org/php/getParsedLog.php?id=38812931&tree=Mozilla-Inbound&full=1

...but I don't see the WebIDL files being regenerated or GamepadBinding files being compiled.

Comment 2

[(not currently active) Ted Mielczarek]

The plot thickens! I can repro this locally by doing:
hg up 74ef5120ae2f
<build for android>
hg up 885b5b8fd7d9
<rebuild>

The build succeeds, but testing shows that while most of the Gamepad API is there (window.Gamepad is defined, the events work), navigator.getGamepads is not defined. That comes from here:
http://hg.mozilla.org/mozilla-central/annotate/b1d730203bb6/dom/webidl/Navigator.webidl#l287

So we must not be rebuilding that preprocessed webidl or something like that.

Comment 3

[(not currently active) Ted Mielczarek]

Grepping for Gamepad in $objdir/dom/bindings/Navigator.webidl comes up empty, so we're not re-preprocessing that file when the set of preprocessor defines changes.

Comment 4

[Takanori MATSUURA]

Bug 852935 is fixed.

Comment 5

[Takanori MATSUURA]

Reopend as per bug 1114669 comment 2.