Closed Bug 1003975 Opened 6 years ago Closed 6 years ago

Clang Static Analysis: useless declaration in jit

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch jit-minor-fix.diff (obsolete) — Splinter Review
The attached patch fixes a warning detected by scan-build, the clang static analyzer.
Attachment #8415441 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8415441 [details] [diff] [review]
jit-minor-fix.diff

Review of attachment 8415441 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/TypePolicy.cpp
@@ -777,1 @@
>      }

style-nit: remove the braces too [1].

[1] https://wiki.mozilla.org/JavaScript:SpiderMonkey:Coding_Style#Other_whitespace
Attachment #8415441 - Flags: review?(nicolas.b.pierron) → review+
Attachment #8415441 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/d74ecd0b08ba
Assignee: nobody → sledru
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.