Clang Static Analysis: useless declaration in jit

RESOLVED FIXED in mozilla32

Status

defect
RESOLVED FIXED
5 years ago
Last year

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

(Blocks 1 bug)

unspecified
mozilla32
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
Posted patch jit-minor-fix.diff (obsolete) — Splinter Review
The attached patch fixes a warning detected by scan-build, the clang static analyzer.
Assignee

Updated

5 years ago
Attachment #8415441 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8415441 [details] [diff] [review]
jit-minor-fix.diff

Review of attachment 8415441 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/TypePolicy.cpp
@@ -777,1 @@
>      }

style-nit: remove the braces too [1].

[1] https://wiki.mozilla.org/JavaScript:SpiderMonkey:Coding_Style#Other_whitespace
Attachment #8415441 - Flags: review?(nicolas.b.pierron) → review+
Assignee

Comment 2

5 years ago
Attachment #8415441 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/d74ecd0b08ba
Assignee: nobody → sledru
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.