1004146 - new Tarako Marketplace

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Wil Clouser [:clouserw]]

Attachment: update tarako marketplace; 2014-04-30

We have a new marketplace for Tarako.  Marking this 1.3T+

PR is at https://github.com/mozilla-b2g/gaia/pull/18845

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8415551 [details] [review]
update tarako marketplace; 2014-04-30

Stealing review.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

1.3t: https://github.com/mozilla-b2g/gaia/commit/a8c63ffaddbf436b355fb7f6b962868924995c83

Comment 3

[Kevin Grandon :kgrandon]

Reverted due to breaking the tree and not having a proper commit message: https://github.com/mozilla-b2g/gaia/commit/ccb0ac659c209cd84e2e6be9887cbf22faa18334

Comment 4

[Wil Clouser [:clouserw]]

https://github.com/mozilla-b2g/gaia/pull/18867 has a commit message with this bug number in it

Comment 5

[Wil Clouser [:clouserw]]

1403        kgrandon │ clouserw: if you want to needinfo? me I can ask some folks on the a-team to lend us a hand.

Comment 6

[Kevin Grandon :kgrandon]

Hey Zac - any chance for a quick look at the pull request in comment 4 here? We're updating Marketplace for 1.3t to remove the iframe, and when we do - the test seems to fail.

Comment 7

[Zac C (:zac)]

Attachment: result.html

(In reply to Kevin Grandon :kgrandon from comment #6)
> Hey Zac - any chance for a quick look at the pull request in comment 4 here?
> We're updating Marketplace for 1.3t to remove the iframe, and when we do -
> the test seems to fail.

Afraid the failure is legitimate - see the report attachment.

(Apologies this report has been broken for some time on Travis but is easy to generate locally)

Comment 8

[Zac C (:zac)]

Pardon I forgot to say, the test modification is fine.

I think the test is failing because Marionette is trying to switch to the frame but it's being destroyed before the action can be completed.

Thus if the marketplace does load properly the test should be fine.

Comment 9

[Wil Clouser [:clouserw]]

It's easy to generate the Marketplace not loading locally?  What are you seeing?  It looks like you wrote the original tests - I need help repairing them for this patch.  I'm not a gaia dev but this is a 1.3T+ bug.  I've looked for you on IRC for a couple of days but haven't seen you - I'm clouserw on there, let's chat.

Comment 10

[Zac C (:zac)]

Thing is it's not a problem with the test.

Travis is using this binary:
http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-b2g28_v1_3/b2g-28.0.multi.linux-x86_64.tar.bz2

Then it's using a gaia profile generated with "DESKTOP_SHIMS=1 make"

If you dl/unpack that binary, then build a Gaia profile as above.

Then start then using "b2g-bin -profile /path/to/profile" , complete the FTU then try to load marketplace you'll get the same error.

In the console it reads:
JavaScript error: about:neterror?e=fileNotFound&u=app%3A//marketplace.firefox.com/index.html&c=UTF-8&f=app&m=https%3A//marketplace.firefox.com/marketplace-package.webapp&d=Firefox%20can%27t%20find%20the%20file%20at%20app%3A//marketplace.firefox.com/index.html., line 560: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIDOMLocation.reload]

Comment 11

[Kevin Grandon :kgrandon]

I'm having trouble with my Tarako and can't spend too much more time on this. We've verified that the marketplace works on a device, so let's disable the test and ship this. I've filed bug 1005241 to re-enable the test.

Comment 12

[Kevin Grandon :kgrandon]

Attachment: Github pull request - Update Tarako Marketplace

Comment 13

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/2c3de85948b8071e9f72f36a513bfa16a5372bdb