Closed
Bug 1004168
Opened 10 years ago
Closed 10 years ago
Add an INI file option to prevent requiring a reboot when there are files in use.
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
Firefox 32
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
(Whiteboard: [qa-] )
Attachments
(1 file)
7.77 KB,
patch
|
jimm
:
review+
Sylvestre
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This is to support bug 994882
Assignee | ||
Comment 1•10 years ago
|
||
Jim, we need to be able to bypass the reboot logic in the installer for bug 994882 while still removing files that are in use. The number of changes required to do it for all of the installer cases is way too risky at this time as I see it so I am going with dirt simple method. Thanks!
Attachment #8415580 -
Flags: review?(jmathies)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8415580 [details] [diff] [review] patch rev1 Looks ok to me.
Attachment #8415580 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Pushed to fx-team https://hg.mozilla.org/integration/fx-team/rev/cfd5a38a44c5
Flags: in-testsuite-
Target Milestone: --- → Firefox 32
https://hg.mozilla.org/mozilla-central/rev/cfd5a38a44c5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8415580 [details] [diff] [review] patch rev1 [Approval Request Comment] Bug caused by (feature/regressing bug #): None. This is to support bug 928173 User impact if declined: We would need to hold off on bug 928173 until this bug rides the trains and hence will have to hold off on getting users on old versions onto the latest version. Testing completed (on m-c, etc.): This has been on m-c and I tested locally. Risk to taking this patch (and alternatives if risky): Minimal. This change applies to installing using an ini file which is not the usual install flow for users. String or IDL/UUID changes made by this patch: None
Attachment #8415580 -
Flags: approval-mozilla-beta?
Attachment #8415580 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8415580 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Updated•10 years ago
|
tracking-firefox30:
--- → ?
Updated•10 years ago
|
Attachment #8415580 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•10 years ago
|
Updated•10 years ago
|
status-b2g-v1.4:
--- → fixed
Comment 9•10 years ago
|
||
Robert, is there any further testing you think would be useful for this, that QA can help out with? Thanks!
Flags: needinfo?(robert.strong.bugs)
Assignee | ||
Comment 10•10 years ago
|
||
I don't think it would be a good use of time to further test this patch though if I can think of something I'll needinfo you and include the testing I think would be useful. Thanks!
Flags: needinfo?(robert.strong.bugs)
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•