1004168 - Add an INI file option to prevent requiring a reboot when there are files in use.

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

This is to support bug 994882

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Jim, we need to be able to bypass the reboot logic in the installer for bug 994882 while still removing files that are in use. The number of changes required to do it for all of the installer cases is way too risky at this time as I see it so I am going with dirt simple method. Thanks!

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8415580 [details] [diff] [review]
patch rev1

Looks ok to me.

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/cfd5a38a44c5

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cfd5a38a44c5

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 8415580 [details] [diff] [review]
patch rev1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): None. This is to support bug 928173
User impact if declined: We would need to hold off on bug 928173 until this bug rides the trains and hence will have to hold off on getting users on old versions onto the latest version.
Testing completed (on m-c, etc.): This has been on m-c and I tested locally.
Risk to taking this patch (and alternatives if risky): Minimal. This change applies to installing using an ini file which is not the usual install flow for users.
String or IDL/UUID changes made by this patch: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1ee6ba74d90f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/afcec252f3b7

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/afcec252f3b7

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Robert, is there any further testing you think would be useful for this, that QA can help out with?  Thanks!

Comment 10

[Robert Strong (they/them - no direct email)]

I don't think it would be a good use of time to further test this patch though if I can think of something I'll needinfo you and include the testing I think would be useful. Thanks!