Closed Bug 1004185 Opened 6 years ago Closed 6 years ago

Do a second HTTP cache v2 trial on Firefox Desktop

Categories

(Core :: Networking: Cache, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

Attachments

(1 file)

Despite we need to fix talos and one last test (according the runs on Gum we have now) we could do another public test in the meantime.

We can use again the patches from bug 967693.  I will merge them and request review.

I don't remember how/who we've announced this the last time, jason?
Attached patch v1Splinter Review
It's that easy..!
Attachment #8415594 - Flags: review?(jduell.mcbugs)
Comment on attachment 8415594 [details] [diff] [review]
v1

Review of attachment 8415594 [details] [diff] [review]:
-----------------------------------------------------------------

Just to be clear: this is turning cache2 on just for desktop, and not android/b2g, and also not our buildbots, right?
(In reply to Jason Duell (:jduell) from comment #2)
> Just to be clear: this is turning cache2 on just for desktop, and not
> android/b2g, and also not our buildbots, right?

Exactly.  It does the same thing as the last time.  The "temp on" pref C++ handling code was left in, the talos specific preference to disable this "temp on" pref was left in too.  So, yes - this only enables cache2 for Firefox Desktop users.
When is the intended date to revert this temporary" trial? Sounds like a few days?
Yes, just a few days.  With a little luck we'll actually be able to fully land the cache immediately/shortly after that.
Comment on attachment 8415594 [details] [diff] [review]
v1

Review of attachment 8415594 [details] [diff] [review]:
-----------------------------------------------------------------

I think we're good to land the trial on m-c for a few days.
Attachment #8415594 - Flags: review?(jduell.mcbugs) → review+
Bug 913819 comment 18 makes it sound like we want to land that bug before we turn this on.
Depends on: 913819
(In reply to Jason Duell (:jduell) from comment #7)
> Bug 913819 comment 18 makes it sound like we want to land that bug before we
> turn this on.

Michal seems to be offline today.  I will land the patch for him.
https://hg.mozilla.org/mozilla-central/rev/acbdfd79dbb5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Depends on: 1005963
Blocks: 1006197
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.