Closed
Bug 1004196
Opened 10 years ago
Closed 10 years ago
make all default ipdl argument names be in form "aFoo" instead of "foo"
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file, 1 obsolete file)
|
3.98 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8415591 -
Flags: review?(bent.mozilla)
Comment on attachment 8415591 [details] [diff] [review] fix v1.0 Review of attachment 8415591 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! ::: ipc/ipdl/ipdl/lower.py @@ +3355,5 @@ > ## DestroySubtree(bool normal) > + whyvar = ExprVar('aWhy') > + subtreewhyvar = ExprVar('aSubtreeWhy') > + kidsvar = ExprVar('aKids') > + ivar = ExprVar('aI') I hope not all of these are actually necessary?
Attachment #8415591 -
Flags: review?(bent.mozilla) → review+
(In reply to ben turner [:bent] (use the needinfo? flag!) from comment #1) > Comment on attachment 8415591 [details] [diff] [review] > fix v1.0 > > Review of attachment 8415591 [details] [diff] [review]: > ----------------------------------------------------------------- > > Thanks! > > ::: ipc/ipdl/ipdl/lower.py > @@ +3355,5 @@ > > ## DestroySubtree(bool normal) > > + whyvar = ExprVar('aWhy') > > + subtreewhyvar = ExprVar('aSubtreeWhy') > > + kidsvar = ExprVar('aKids') > > + ivar = ExprVar('aI') > > I hope not all of these are actually necessary? Yeah, they aren't actually argument variables. Will drop them from the patch.
Attachment #8415591 -
Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/5f56d502fca1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•