Closed
Bug 1004370
Opened 11 years ago
Closed 11 years ago
Add personal tags to Bug.get
Categories
(Bugzilla :: WebService, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: mtyson, Assigned: mtyson)
References
Details
Attachments
(1 file, 1 obsolete file)
1.33 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
This patch will allow Bug.get to fetch a users personal tags.
This is an optional parameter and needs to be requested by using 'include_fields'
This depends on 992091 due to tag being renamed to tags.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: webservice → mtyson
Attachment #8415748 -
Flags: review?(glob)
Comment on attachment 8415748 [details] [diff] [review]
Patch to add tag support to Bug.get
Review of attachment 8415748 [details] [diff] [review]:
-----------------------------------------------------------------
the code looks good, but the perldoc needs to be moved. should be a quick r+ once that's moved.
::: Bugzilla/WebService/Bug.pm
@@ +2569,5 @@
> +=item C<tags>
> +
> +C<array> of C<string>s. Each array item is a tag name.
> +
> +Note that tags are personal to the currently logged in user.
this is in the wrong location - it's with the set of _default fields.
please it in a new block before prefixed with the follow sentence (or similar):
These fields are returned only by specifying "_extra" or the field name in "include_fields".
Attachment #8415748 -
Flags: review?(glob) → review-
Assignee | ||
Comment 3•11 years ago
|
||
Patch updated with requested changes.
Attachment #8415748 -
Attachment is obsolete: true
Attachment #8418399 -
Flags: review?(glob)
Comment on attachment 8418399 [details] [diff] [review]
Tags support for bug.get
Review of attachment 8418399 [details] [diff] [review]:
-----------------------------------------------------------------
r=glob
Attachment #8418399 -
Flags: review?(glob) → review+
Updated•11 years ago
|
Flags: approval? → approval+
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
d2c2138..617eeba master -> master
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•