1004374 - [Skia] Remove Moz2D requirement for SK_SUPPORT_LEGACY_LAYERRASTERIZER_API

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[George Wright (:gw280) (needinfo me!)]

Skia are deprecating some of their layer rasterizer APIs, and to ease the transition the old ones are still available behind an ifdef SK_SUPPORT_LEGACY_LAYERRASTERIZER_API

We should remove our usage of these old APIs and switch to the new ones.

Ideal as an intern bug.

Comment 1

[George Wright (:gw280) (needinfo me!)]

https://codereview.chromium.org/285443002/

Comment 2

[Walter Litwinczyk [:walter]]

Attachment: Removed usage of legacy api

Comment 3

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8427386 [details] [diff] [review]
Removed usage of legacy api

Review of attachment 8427386 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine. I was mostly concerned about the refcnt of the SkLayerRasterizer object but this looks correct.

Comment 4

[George Wright (:gw280) (needinfo me!)]

That being said, I'd rather we used an SkAutoTUnref<SkLayerRasterizer> instead of calling SkSafeUnref() on the returned object.

Comment 5

[Walter Litwinczyk [:walter]]

Attachment: skia_bug_1004374

Changed SkSafeUnref -> SkAutoTUnref

Comment 6

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8443644 [details] [diff] [review]
skia_bug_1004374

Review of attachment 8443644 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, with minor nit (basically to match the way we use SkAutoTUnref in the rest of DrawTargetSkia, such as in Init()).

::: gfx/2d/DrawTargetSkia.cpp
@@ +537,5 @@
>    SetPaintPattern(maskPaint, aMask, tmpBitmap);
>    
> +  SkLayerRasterizer::Builder builder;
> +  builder.addLayer(maskPaint);
> +  SkAutoTUnref<SkRasterizer> raster(paint.mPaint.setRasterizer(builder.detachRasterizer()));

I would really rather have:

SkAutoTUnref<SkRasterizer> raster(builder.detachRasterizer());
paint.mPaint.setRasterizer(raster.get());

Comment 7

[Walter Litwinczyk [:walter]]

Attachment: skia_bug_1004374

r=gw280 carried forward

Comment 8

[Walter Litwinczyk [:walter]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=681b8d426f11

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4991c65b2a4

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b4991c65b2a4