1004410 - Provide mach command for running mochitests against the distribution dir or arbitrary binaries

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[:Gijs (he/him)]

I needed this for bug 971096, but I've often wanted to do this in order to run tests against downloaded builds.

Comment 1

[:Gijs (he/him)]

Attachment: allow running mochitests against an arbitrary binary,

Joel, does this look right to you? It works on my OS X machine, but I don't know if that's just luck or if this is entirely right. :-)

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8415816 [details] [diff] [review]
allow running mochitests against an arbitrary binary,

Review of attachment 8415816 [details] [diff] [review]:
-----------------------------------------------------------------

Could you provide an example in the help, i.e. --app-override=/usr/bin/firefox or something like that.

::: testing/mochitest/mach_commands.py
@@ +354,5 @@
>  
> +        if app_override == "dist":
> +            options.app = self.get_binary_path(where='staged-package')
> +        elif app_override:
> +            options.app = app_override

I like the addition of 'dist' as a shortcut and that it is documented in the help!

Comment 3

[:Gijs (he/him)]

Sweet, thanks for the quick review!

remote:   https://hg.mozilla.org/integration/fx-team/rev/bd51ceeecb94

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bd51ceeecb94