Closed Bug 1004410 Opened 10 years ago Closed 10 years ago

Provide mach command for running mochitests against the distribution dir or arbitrary binaries

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

I needed this for bug 971096, but I've often wanted to do this in order to run tests against downloaded builds.
Joel, does this look right to you? It works on my OS X machine, but I don't know if that's just luck or if this is entirely right. :-)
Attachment #8415816 - Flags: review?(jmaher)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8415816 [details] [diff] [review]
allow running mochitests against an arbitrary binary,

Review of attachment 8415816 [details] [diff] [review]:
-----------------------------------------------------------------

Could you provide an example in the help, i.e. --app-override=/usr/bin/firefox or something like that.

::: testing/mochitest/mach_commands.py
@@ +354,5 @@
>  
> +        if app_override == "dist":
> +            options.app = self.get_binary_path(where='staged-package')
> +        elif app_override:
> +            options.app = app_override

I like the addition of 'dist' as a shortcut and that it is documented in the help!
Attachment #8415816 - Flags: review?(jmaher) → review+
Sweet, thanks for the quick review!

remote:   https://hg.mozilla.org/integration/fx-team/rev/bd51ceeecb94
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/bd51ceeecb94
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla32
Depends on: 1173691
You need to log in before you can comment on or make changes to this bug.